Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old implementation #87

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Sep 23, 2021

Description

Remove old implementation: find out more - #80 and decision.

As the changes with the new implementation would be a lot and it would be difficult to do a review, I decided to create a new branch next to master - spa-scratch - where I will first remove the old implementation and gradually add new things.

Related issue(s)
Part of #80

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu changed the base branch from master to spa-scratch September 23, 2021 11:10
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@magicmatatjahu magicmatatjahu merged commit 6bd9e0d into asyncapi:spa-scratch Sep 23, 2021
@magicmatatjahu magicmatatjahu deleted the spa-scratch/delete-old-implementation branch September 23, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants