refactor: update maintainers list, introduce isTscMember key, and remove tsc_member.json file #1722
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
14Richa
changed the title
There was a problem hiding this comment.
I think this PR can come hand in hand with changes from community repo
so remove tsc members doc, and operate already on maintainers file, just in UI code you will need to make sure that from maintainers.yml you read only the ones that are marked as maintainers
14Richa
requested review from
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
I would like to clarify a few points regarding the comment :
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1722--asyncapi-website.netlify.app/ |
14Richa
changed the title
|
@14Richa yes, we need a flag that determines if maintainer is a TSC member. Human will add such information to the Original How someone becomes a maintainer in any existing asyncapi repo? -> https://github.com/asyncapi/community/blob/master/Become-maintainer-in-existing-project.md |
14Richa
changed the title
There was a problem hiding this comment.
just one small stuff that you could not know about
plan should be that we first merge asyncapi/community#720 and then this PR
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
There was a problem hiding this comment.
All good, we just need to wait for asyncapi/community#720 before we merge this one
|
@14Richa there is a merge conflict that you need to address since you remove tsc member json, but it was just updated in master, you need to confirm removal basically |
…ite into 14Richa/change-json-to-yaml
|
/rtm |
|
/rtm |
Description
This PR updates the maintainers list by introducing a new file called
Maintainers.jsonand removing the oldtsc_member.jsonfile. The newMaintainers.jsonfile contains the same data as the previoustsc_member.json, but with the addition of a new boolean key calledisTscMember. This key indicates whether a maintainer is a member of the TSC or not.To reflect this change on the website, the Maintainers.json file is called in a React component and filtered so that only maintainers whose isTscMember value is true are displayed.