Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blog): asyncapi mentorship program summary(2023) #3042

Merged
merged 12 commits into from
Jun 27, 2024
Merged

chore(blog): asyncapi mentorship program summary(2023) #3042

merged 12 commits into from
Jun 27, 2024

Conversation

AceTheCreator
Copy link
Member

Here's a summary of the 2nd edition of the AsyncAPI mentorship program.

Happy for a lovely review.

@AceTheCreator AceTheCreator changed the title chore(blog): asyncapi mentorship summary(2023) chore(blog): asyncapi mentorship program summary(2023) Jun 13, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 13, 2024 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bd1f53c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/667d369896be670008265383
😎 Deploy Preview https://deploy-preview-3042--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mayaleeeee
Copy link
Collaborator

Mayaleeeee commented Jun 14, 2024 •
edited
Loading

Hey @AceTheCreator , great job on the blog!

Here are my suggestions:

  1. Let's highlight key numbers and names in the blog to make it easier for readers to spot important details and make them more noticeable.

    • In the beginning section
      Screenshots_2024-06-14-10-41-25.png

    • The Results (just the numbers under this paragraph is okay)
      Screenshots_2024-06-14-10-47-40.png

    • Project success - (change 'eight projects' to '8 projects' for consistency since the figure is what you have been using). Also, in the same project section, attach names of mentees to each project - this method will give each project a personal touch.
      Screenshots_2024-06-14-10-48-37.png

    • In the 'What's Next' section, highlight the date the mentorship will commence, 20th of June, 2024.
      Screenshots_2024-06-14-10-49-21.png

PS: If highlighting all the numbers in a paragraph would be overwhelming, you could use bold text or a different color for the most important numbers.

  1. The second suggestion is to change the section titled 'Mentees Success' to 'Impact of Mentorship Program'.

    Why? IMHO, the current title doesn't fully relate to the section's content. "Impact of Mentorship Program" better captures the overall effects on both the mentees and the community, making it clearer and more specific. (You might have a different opinion)

3. Improve the 'How to Connect' section
The use of the word just in the phrase "Just make sure to follow our Slack etiquette and the code of conduct" can sometimes downplay the importance of these guidelines. We aim to emphasize their significance for a positive community experience.

Consider revising to:

To get involved, join our Slack workspace. Be sure to follow our Slack etiquette and the code of conduct to make the most of your experience.

@quetzalliwrites
Copy link
Member

I agree with Maya's point about losing data points in the multiple paragraphs of this post. However, instead of bolding/highlighting numbers, I have added a table with the most important data points.

quetzalliwrites
quetzalliwrites previously approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited/fixed the post and think it's good now 🚢

@AceTheCreator
Copy link
Member Author

Is there anything you'd like me to add, @derberg?

derberg
derberg reviewed Jun 20, 2024
View reviewed changes
markdown/blog/2023-mentorship-summary.md Outdated

While all the selected projects received outstanding contributions from the mentees, I'm pleased to share some of the successes experienced by the mentees who participated in this program after its completion.

- **Path to Maintainership**: After the program, some mentees, including Maya, Ansh, Sambhav, and Rishi, became maintainers of certain projects due to the knowledge they gained during the mentorship program.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more names, Vaishnavi - Rohit and Joy

how about we make it more explicit? give them bigger shout out in the article

so have sub-bullet points, naming them all and what maintainer duties they took up?

  • Maya - became designer maintainer in website
  • Ansh - became committer maintainer in website
  • Sambhav - became code triager maintainer in website
  • Rishi - became maintainer in nodejs-template
  • Vaishnavi - became docs triager maintainer in website
  • Rohit - became docs triager maintainer in website
  • Joy - became docs triager maintainer in website

linking to their profiles, and to repositories?

also in the other section you could mention who decided to me mentor this year - like explicitly

cc @alequetzalli

derberg
derberg reviewed Jun 20, 2024
View reviewed changes
markdown/blog/2023-mentorship-summary.md Outdated

- **[Website UI Kit design/dev project](https://github.com/asyncapi/design-system/issues/4)**: Thanks to the success of this program, the AsyncAPI website got a design system, which is something we really wanted. Now whenever someone works on the website, there's a consistent way of doing things design-wise.
- **[Simulator Desktop Application](https://github.com/asyncapi/community/issues/691)**: The AsyncAPI simulator, which started as a project in GSoC '21 and was just a command-line tool, now has a version that works on desktops. Now it's easier for people to use it right from their computers.
- **[Documenting how different protocols work with AsyncAPI](https://github.com/orgs/asyncapi/discussions/533)**: A group of four candidates embarked on a detailed project documenting the interaction between various protocols and AsyncAPI. Thanks to the program, they developed and published two series of tutorials covering how to use AsyncAPI with the [Kafka]([https://www.asyncapi.com/docs/tutorials/websocket](https://www.asyncapi.com/docs/tutorials/websocket)) and [Websocket]([https://www.asyncapi.com/docs/tutorials/websocket](https://www.asyncapi.com/docs/tutorials/websocket)) protocols.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw the markdown links to docs that you have here look weird

in the end you should just have relative link like /docs/tutorials/websocket

just noticed that for kafka you point to websocket

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also maybe add that since the release of kafka section it got already 3559 and for websocket 2698 views

don't remember when they were released but probably few months ago

AceTheCreator and others added 2 commits June 21, 2024 12:19
@AceTheCreator @derberg
Update markdown/blog/2023-mentorship-summary.md
ebcc668 
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@AceTheCreator
added suggested changes
5416fd5
@AceTheCreator
Copy link
Member Author

Added suggested changes @derberg

derberg
derberg previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@AceTheCreator AceTheCreator marked this pull request as ready for review June 27, 2024 09:30
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jun 27, 2024 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3042--asyncapi-website.netlify.app/

@AceTheCreator
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 269b910 into asyncapi:master Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thulieblack thulieblack thulieblack approved these changes

@Mayaleeeee Mayaleeeee Mayaleeeee approved these changes

@derberg derberg derberg left review comments

@quetzalliwrites quetzalliwrites quetzalliwrites left review comments

@sambhavgupta0705 sambhavgupta0705 Awaiting requested review from sambhavgupta0705

@BhaswatiRoy BhaswatiRoy Awaiting requested review from BhaswatiRoy

@J0SAL J0SAL Awaiting requested review from J0SAL

@TRohit20 TRohit20 Awaiting requested review from TRohit20

@VaishnaviNandakumar VaishnaviNandakumar Awaiting requested review from VaishnaviNandakumar

@akshatnema akshatnema Awaiting requested review from akshatnema akshatnema is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@anshgoyalevil anshgoyalevil Awaiting requested review from anshgoyalevil anshgoyalevil is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AceTheCreator @Mayaleeeee @quetzalliwrites @asyncapi-bot @derberg @thulieblack