chore: split website data build process to several steps #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
quetzalliwrites,
asyncapi-bot-eve,
fmvilas and
derberg
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-830--asyncapi-website.netlify.app/ |
quetzalliwrites
previously approved these changes
Jun 28, 2022
magicmatatjahu
force-pushed
the
fix/build-process
branch
from
ee82184
to
4843ff7
Compare
|
I don't remember why this PR at all anymore 😆 |
|
I think you wanted to refactor scripts, split the |
|
are we closing it? I prefer doing it the way we do it not, that each new script gets it's own folder, rather refactor all like this unless you have time to update the PR |
|
@derberg Yeah, I will close. We should try make this approach that you wrote, but in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
That PR doesn't change anything in styling and similar things in our website. It only splits posts building process to several steps, each part like blog-posts, jobs etc now will be located in separate files, usually with another shapes to easier handle data in appropriate pages.
There is a lot of code, but it's because I had to change the way of getting some values - the keys in the objects have changed.