Remove references to sensor_msgs::PointCloud #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use sensor_msgs::PointCloud2 instead of sensor_msgs::PointCloud.
|
@at-wat any idea why this happened? https://travis-ci.org/github/at-wat/mcl_3dl/jobs/716918432#L3455 |
|
It's a bug in the latest version in gh-pr-comment. I'm going to fix it. |
No rush. Thanks!. Let me know if there is anything I can help with. |
[#833] PASSED on noeticTested on Alpine ROS [#833] PASSED on kineticAll tests passed[#833] PASSED on melodicAll tests passed |
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 94.52% 94.57% +0.04%
==========================================
Files 32 32
Lines 1716 1713 -3
==========================================
- Hits 1622 1620 -2
+ Misses 94 93 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not look like the use of
sensor_msgs::PointCloudis necessary. For consistency, usingsensor_msgs::PointCloud2seems better.