Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resampling for huge particle size #90

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Fix resampling for huge particle size #90

merged 1 commit into from
Dec 14, 2017

Conversation

at-wat
Copy link
Owner

@at-wat at-wat commented Dec 14, 2017 •
edited
Loading

  • All-zero particles have appeared on resampling if the particle size is very large.
  • Assert due to invalid norm of quaternion occured.

@at-wat
Fix resampling for huge particle size
db4d317 
* All-zero particles have appeared on resampling if the particle size is very large.
* Also, add iterator.
@at-wat at-wat self-assigned this Dec 14, 2017
@at-wat
Copy link
Owner Author

at-wat commented Dec 14, 2017

PASSED on kinetic

All tests passed

Skipping "src/mcl_3dl/package.xml": 'tests'
build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests
build/test_results/mcl_3dl/gtest-test_nd.xml: 1 tests
build/test_results/mcl_3dl/gtest-test_pf.xml: 2 tests
build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests
build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests
build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests
build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests
build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests
build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests
build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests
Summary: 20 tests, 0 errors, 0 failures, 0 skipped

@at-wat
Copy link
Owner Author

at-wat commented Dec 14, 2017

PASSED on indigo

All tests passed

Skipping "src/mcl_3dl/package.xml": 'tests'
build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests
build/test_results/mcl_3dl/gtest-test_nd.xml: 1 tests
build/test_results/mcl_3dl/gtest-test_pf.xml: 2 tests
build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests
build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests
build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests
build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests
build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests
build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests
build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests
Summary: 20 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat merged commit 5031d04 into master Dec 14, 2017
@at-wat at-wat deleted the fix-resampling branch December 14, 2017 10:09
@at-wat at-wat mentioned this pull request Dec 15, 2017
Merged
at-wat added a commit that referenced this pull request Dec 15, 2017
@at-wat
Fix particle resize (#92)
d68762a 
same fix as #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@at-wat