Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title for Popup window #19

Open
apn99 opened this issue Apr 5, 2012 · 2 comments
Open

Title for Popup window #19

apn99 opened this issue Apr 5, 2012 · 2 comments

Comments

@apn99
Copy link

apn99 commented Apr 5, 2012

Titles are not shown , when opening a link in the pop up window. Do you have know about this issue or am I missing something?. The title in popup window is working in the chromium cefclient...Also noticed that the pop up window icon is not same as Web view window icon. currently popup icon shows some default icon.

@apn99
Copy link
Author

apn99 commented Apr 12, 2012

Here is the fix I made in the clientAdapter.cpp file in the eventhandler OnTitleChange. Please let me know,if the fix looks OK for displaying popup titles.
void ClientAdapter::OnTitleChange(CefRefPtr browser, const CefString& title)
{
HWND lHwnd = browser->GetWindowHandle();
if(_browserHwnd == lHwnd)
{
_browserControl->Title = toClr(title);
}
else
{
SetWindowText(lHwnd, std::wstring(title).c_str());
}
}

@ataranto
Copy link
Owner

ataranto commented Mar 8, 2013

actually it looks like ClientAdapter::OnTitleChange() always updates the title of the parent window, regardless of which popup window's title actually changed. will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants