-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PotentialActions #102
Comments
In short, it would be a useful feature to include, but I don't have anything lined up at present. I've got some obligations in front of me that would prevent me from working on this directly, but Pull Requests are welcome. I took a stab at this around March 2020, but ran into a few walls when doing so. It's been long enough now that I only have a vague sense of the issues. I dug back through some prototype branches and I see where I stubbed out the beginnings of the work, but I didn't get far: https://github.com/atc0005/go-teams-notify/blob/test-extended-messagecard-type/messagecard.go This is back before I worked to cleanup the prototype code and get it ready for inclusion in the |
Here you go: #103 |
@nmaupu Thanks. I'm looking over it. It also looks like GitHub has recently changed how workflows are handled for forks. Instead of running automatically as before, I had to "approve" them first. |
Current thinking:
I estimate releasing the new version within a week, hopefully within the next few days. |
TODO (note to self, pulled from #103 (comment)):
|
- Add doc comments where needed - Reorder struct fields to resolve `maligned` linter complaints - Formatting tweaks - intended to match existing code formatting (e.g., whitespace, line wrapping, etc) refs GH-102
- Add new method for `MessageCardSection` to compliment recently added method specific to the `MessageCard`. - Add doc comment for `MessageCard.PotentialActions` - was intended for last PR, but was overlooked refs GH-102
Validation work appears to be the next step. Unordered thoughts:
|
Currently the function definition does not return an error, so we'd have to modify that. Since a tagged release hasn't been made yet, I feel that we can do so without violating semantic versioning. |
Add two helper functions to handle: - validation of `*MessageCardPotentialAction` values - appending `*MessageCardPotentialAction` values to the `PotentialAction` field for both `MessageCard` and `MessageCardSection` values The `NewMessageCardPotentialAction` factory function has been modified to return an `error`. This provides validation at both entry points: - creating a new value - adding a value to an existing collection **NOTE:** This change is considered to be compatible with semantic versioning because the support for `PotentialActions` has not yet landed in a stable public release, leaving the final form subject to change until the next public release. refs GH-102
Add two helper functions to handle: - validation of `*MessageCardPotentialAction` values - appending `*MessageCardPotentialAction` values to the `PotentialAction` field for both `MessageCard` and `MessageCardSection` values The `NewMessageCardPotentialAction` factory function has been modified to return an `error`. This provides validation at both entry points: - creating a new value - adding a value to an existing collection **NOTE:** This change is considered to be compatible with semantic versioning because the support for `PotentialActions` has not yet landed in a stable public release, leaving the final form subject to change until the next public release. refs GH-102
Hi !
Is there any plan to support potential actions in MessageCards as per https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using ?
The text was updated successfully, but these errors were encountered: