-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added structs to supports potential actions #103
Conversation
Thanks for submitting this. It will take me some time to step through the changes and offer detailed feedback, but I wanted to go ahead and throw out some unordered items as they come to mind:
|
@nmaupu I meant to follow-up before now, apologies for the silence here. Do you happen to have any test/prototype client code which uses the functionality added by this PR? I'm asking before I make plans to try and work in changes to a small project of my own in order to better test the proposed changes. |
No prob!
No I don't ATM :/ |
I posted this question in-line here: I'm used to GitHub displaying the applicable portion of the diff alongside comments within the PR "thread". Not sure why it didn't do so this time. |
Thanks for your patience on this. I've gotten far enough with a set of changes for a CLI client that I'm getting a good feel for the features this PR adds. Overall, this appears to be a great addition to the library. Are you interested in making further changes, or would you like to smooth off any rough edges (e.g., add doc comments in a few places) and consider this PR done? If you'd like to make further changes, I've got some suggestions, but I can hold those for a follow-up PR if you want. |
This commit implements support for specifying multiple URLs via CLI flags. These URLs are exposed as labelled "buttons" towards the bottom of the generated Microsoft Teams message. This commit also includes modified, vendored WIP changes from atc0005/go-teams-notify#103 that have yet to be merged into that project. The intent is to update to the latest stable tag once that PR and any follow-up PRs are merged. Light documentation updates have been applied, including usage of the new `--target-url` flag. refs atc0005/go-teams-notify#103 refs #148 refs #120
4e5b465
to
b9e05e8
Compare
b9e05e8
to
ac0bc65
Compare
@nmaupu I initially tried to use GitHub to rebase the latest changes from The result is that the branch is up to date with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve the PR as-is, then submit further changes (e.g., linting fixes) as part a later PR. See #102 (comment) and #102 (comment) for specifics.
Thanks again for this work, it's a great addition to the library.
Added support for PotentialActions.
See https://docs.microsoft.com/en-us/outlook/actionable-messages/message-card-reference#actions