Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output for tutorials/table_mug.pcd #89

Closed
seann999 opened this issue Mar 25, 2020 · 3 comments
Closed

Output for tutorials/table_mug.pcd #89

seann999 opened this issue Mar 25, 2020 · 3 comments

Comments

@seann999
Copy link

The output of ./detect_grasps ../cfg/eigen_params.cfg ../tutorials/krylon.pcd looked good, but the output for ../tutorials/table_mug.pcd generates grasps that are far off from the point cloud (at least for me). Is this expected, possibly due to the need of adjusting values in the cfg, or not?

@atenpas
Copy link
Owner

atenpas commented Mar 25, 2020

Yes, this is to be expected. To find grasps on the mug, you have to modify the cfg. The file ../tutorials/table_mug.pcd was part of an old tutorial that does not work with this version of the code anymore. You would want to segment the table and/or use a workspace filter for this file. In general, you always want to customize the cfg for your robot, environment, etc.

@atenpas
Copy link
Owner

atenpas commented Jul 8, 2020

Closing this for now.

@huiwenzhang
Copy link

huiwenzhang commented Feb 1, 2023

Yes, this is to be expected. To find grasps on the mug, you have to modify the cfg. The file ../tutorials/table_mug.pcd was part of an old tutorial that does not work with this version of the code anymore. You would want to segment the table and/or use a workspace filter for this file. In general, you always want to customize the cfg for your robot, environment, etc.

@atenpas why the table_mug.pcd is out of date? I checked the code, the candidate grasps are far from the point cloud is because the sampled origins are wrong. However, according to the visualization code below,

void Plot::plotSamples(const std::vector<int> &index_list,
                       const PointCloudRGBA::Ptr &cloud) {
  PointCloudRGBA::Ptr samples_cloud(new PointCloudRGBA);
  for (int i = 0; i < index_list.size(); i++) {
    samples_cloud->points.push_back(cloud->points[index_list[i]]);
    std::cout << index_list[i] << std::endl;
  }

  plotSamples(samples_cloud, cloud);
}

the sampled cloud is absolutely part of the processed cloud. Why the figure shows that they are from different cloud? As shown in the figure below, points in pink color are sampled points.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants