Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign OpenGL Buffer creation pipeline #41

Open
athanggupte opened this issue Jan 16, 2023 · 0 comments
Open

Redesign OpenGL Buffer creation pipeline #41

athanggupte opened this issue Jan 16, 2023 · 0 comments
Assignees
Labels
enhancement Improve existing features module:core Issues regarding the core engine

Comments

@athanggupte
Copy link
Owner

The current implementation of the OpenGL Buffer creation mechanism involves a diamond inherence from the OpenGL{XYZ}Buffer classes to the Buffer base class through the {XYZ}Buffer abstract class and the OpenGLBuffer abstract class.
This is not only a bad design strategy but can also slow down the code in the long run when a lot of buffers are built and managed.

Redesigning the entire Buffer class hierarchy and the creation pipeline is highly advisable.
Methods to consider:

  • Create a OpenGLBufferFactory which can create the different OpenGL{XYZ}Buffer classes which can avoid the diamond hierarchy and also reduce code repetition.
@athanggupte athanggupte added enhancement Improve existing features module:core Issues regarding the core engine labels Jan 16, 2023
@athanggupte athanggupte self-assigned this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing features module:core Issues regarding the core engine
Projects
None yet
Development

No branches or pull requests

1 participant