Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broadcast username on update #1617

Merged
merged 6 commits into from
Sep 10, 2021
Merged

fix: broadcast username on update #1617

merged 6 commits into from
Sep 10, 2021

Conversation

juniusfree
Copy link
Contributor

@juniusfree juniusfree commented Sep 4, 2021 •
edited

  • This PR fixes Username change not updated (1.0.0-ALPHA.RTC.1 - Remote DB) #1514.
  • This will now allow the username to be updated to every client in the lan-party when one of the clients updated the user name.
  • A new event to send the new user is created in the presence module on the client-side. This event will be triggered when the username on the settings page is updated.
  • A new event is added on the server-side to broadcast the new user name.
  • On the server-side, the atom, athens.self-hosted.clients/clients is also updated when the user name is changed. This is to ensure that the newly connected clients will get the latest list of user names.
  • On the server-side, I'm also thinking if the editing-handler and username-handler can be generalized but I'm unsure yet on how to do it.

@juniusfree juniusfree changed the title fix: broadcast username update fix: broadcast username on update Sep 4, 2021
@juniusfree juniusfree added r/rtc Issues to be resolved as part of the RTC release. t/presence RTC Presence labels Sep 4, 2021
neotyk
neotyk requested changes Sep 6, 2021
View reviewed changes
Copy link
Collaborator

@neotyk neotyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments, 1st about naming, 2nd about actual usage in backend.

src/clj/athens/self_hosted/web/presence.clj Outdated Show resolved Hide resolved
src/clj/athens/self_hosted/web/presence.clj Show resolved Hide resolved
@neotyk neotyk linked an issue Sep 6, 2021 that may be closed by this pull request
Username change not updated (1.0.0-ALPHA.RTC.1 - Remote DB) #1514
Open
@juniusfree
Copy link
Contributor Author

Other todos but not for this PR:

  1. rename clients/add-client! function
  2. consider how renaming will handle failures (e.g. name clash with other clients, server failure)

@neotyk neotyk merged commit 7817d2a into athensresearch:feature/rtc-v1 Sep 10, 2021
RTC Cycle 2: Initial feedback and stability automation moved this from In Review to Done Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neotyk neotyk Awaiting requested review from neotyk

Assignees

@juniusfree juniusfree

Labels
r/rtc Issues to be resolved as part of the RTC release. t/presence RTC Presence
Projects
RTC Cycle 2: Initial feedback and sta...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Username change not updated (1.0.0-ALPHA.RTC.1 - Remote DB)
2 participants
@juniusfree @neotyk