tighten flaky e2e #2034
Merged
tighten flaky e2e #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
filipesilva
commented
Feb 21, 2022
filipesilva
commented
- fix: athena tests should cleanup page
- rfct: add inputInAthena helper
- rfct: ensure title is visible after page creation
- fix: remove timeout from saveLastBlockAndEnter
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/athens-research/athens/7jtUBKfoKfJojvK5AfSevtVvViF9 |
filipesilva
force-pushed
the
flaky-e2e
branch
from
abf6320
to
7568345
Compare
We don't have anything that should take more than a few seconds, and closing the electron app in the CI is prone to timeout
This reverts commit 1f10d69. Reverted because it caused even more flakyness in https://github.com/athensresearch/athens/runs/5280488268?check_suite_focus=true Some tests really do seem to take ~20s. Might be because of boot time for the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.