Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten flaky e2e #2034

Merged
merged 7 commits into from
Feb 22, 2022
Merged

tighten flaky e2e #2034

merged 7 commits into from
Feb 22, 2022

Commits on Feb 21, 2022

  1. fix: athena tests should cleanup page

    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    399a08b View commit details
    Browse the repository at this point in the history

  2. rfct: add inputInAthena helper

    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    c3a831a View commit details
    Browse the repository at this point in the history

  3. rfct: ensure title is visible after page creation

    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    0da7251 View commit details
    Browse the repository at this point in the history

  4. fix: remove timeout from saveLastBlockAndEnter

    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    7568345 View commit details
    Browse the repository at this point in the history

  5. ci: cache the build for e2e

    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    72cfe9c View commit details
    Browse the repository at this point in the history

  6. ci: fail e2e faster 

    We don't have anything that should take more than a few seconds, and
closing the electron app in the CI is prone to timeout
    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    1f10d69 View commit details
    Browse the repository at this point in the history

  7. Revert "ci: fail e2e faster" 

    This reverts commit 1f10d69.

Reverted because it caused even more flakyness in https://github.com/athensresearch/athens/runs/5280488268?check_suite_focus=true

Some tests really do seem to take ~20s.
Might be because of boot time for the app.
    @filipesilva
    filipesilva committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    43966b2 View commit details
    Browse the repository at this point in the history