Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 0.66.0 to ~> 0.67.2 #276

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 0.67.2

Bug fixes

  • #6882: Fix an error for Rails/RedundantAllowNil when not using both allow_nil and allow_blank. (@​koic)
Changelog

Sourced from rubocop's changelog.

0.67.2 (2019-04-05)

Bug fixes

  • #6882: Fix an error for Rails/RedundantAllowNil when not using both allow_nil and allow_blank. (@​koic)

0.67.1 (2019-04-04)

Changes

  • #6881: Set default PreferredName to e for Naming/RescuedExceptionsVariableName. (@​koic)

0.67.0 (2019-04-04)

New features

  • #5184: Add new multiline element line break cops. ([@​maxh][])
  • Add new cop Rails/ActiveRecordOverride that checks for overriding Active Record methods instead of using callbacks. ([@​elebow][])
  • Add new cop Rails/RedundantAllowNil that checks for cases when allow_blank makes allow_nil unnecessary in model validations. ([@​elebow][])
  • Add new Naming/RescuedExceptionsVariableName cop. ([@​AdrienSldy][])

Bug fixes

  • #6761: Make Naming/UncommunicativeMethodParamName account for param names prefixed with underscores. ([@​thomthom][])
  • #6855: Fix an exception in Rails/RedundantReceiverInWithOptions when the body is empty. ([@​ericsullivan][])
  • #6856: Fix auto-correction for Style/BlockComments when the file is missing a trailing blank line. ([@​ericsullivan][])
  • #6858: Fix an incorrect auto-correct for Lint/ToJSON when there are no to_json arguments. (@​koic)
  • #6865: Fix deactivated StyleGuideBaseURL for Layout/ClassStructure. ([@​aeroastro][])
  • #6868: Fix Rails/LinkToBlank auto-correct bug when using symbol for target. ([@​r7kamura][])
  • #6869: Fix false positive for Rails/LinkToBlank when rel is a symbol value. ([@​r7kamura][])
  • Add IncludedMacros param to default rubocop config for Style/MethodCallWithArgsParentheses. ([@​maxh][])
  • #6785: Do not register an offense for Rails/Present or Rails/Blank in an unless else context when Style/UnlessElse is enabled. ([@​rrosenblum][])

Changes

  • #6854: Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. ([@​urbanautomaton][])
  • #5977: Warn for Performance Cops. (@​koic)
  • #6637: Move LstripRstrip from Performance to Style department and rename it to Strip. ([@​anuja-joshi][])
  • #6875: Mention block form of Struct.new in Style/StructInheritance. ([@​XrXr][])
  • #6871: Move Performance/RedundantSortBy, Performance/UnneededSort and Performance/Sample to the Style department. ([@​bbatsov][])

0.66.0 (2019-03-18)

New features

  • #6393: Add AllowBracesOnProceduralOneLiners option to fine-tune Style/BlockDelimiter's semantic mode. ([@​davearonson][])
  • #6383: Add AllowBeforeTrailingComments option on Layout/ExtraSpacing cop. ([@​davearonson][])
  • New cop Lint/SafeNavigationWithEmpty checks for foo&.empty? in conditionals. ([@​rspeicher][])
  • Add new Style/ConstantVisibility cop for enforcing visibility declarations of class and module constants. ([@​drenmi][])
  • #6378: Add Lint/ToJSON cop to enforce an argument when overriding #to_json. ([@​allcentury][])
... (truncated)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.66.0...v0.67.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Apr 5, 2019
@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files           7        7           
  Lines         432      432           
=======================================
  Hits          372      372           
  Misses         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdacb21...7271125. Read the comment docs.

@avdv
Copy link
Collaborator

avdv commented Apr 8, 2019

@dependabot merge

@dependabot-preview dependabot-preview bot merged commit 2366fa1 into master Apr 8, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-tw-0.67.2 branch April 8, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants