Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse attributes with : #50

Closed
atifaziz opened this issue Aug 23, 2015 · 2 comments
Closed

Parse attributes with : #50

atifaziz opened this issue Aug 23, 2015 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@atifaziz
Copy link
Owner

atifaziz commented Aug 23, 2015

Be able to parse attributes in an element that contain : (colon) in it.

Example

document.QuerySelectorAll("meta[property=og:url]")

to find

<meta property="og:url" content="" />

Many website use this because of Facebook


Originally reported on Google Code with ID 50

Reported by ingig@frontur.com on 2011-10-27 15:39:57

@atifaziz
Copy link
Owner Author

atifaziz commented Aug 23, 2015

To fix this, I added this patch
http://code.google.com/p/fizzler/issues/detail?id=44&colspec=ID%20Type%20Status%20Priority%20Milestone%20Component%20Owner%20Summary

And then in Tokener.cs I changed IsNmChar to IsNmHashChar in line 49, see attachement


Reported by ingig@frontur.com on 2011-10-27 16:02:36


@atifaziz atifaziz added enhancement New feature or request and removed Status-New Type-Enhancement labels Aug 23, 2015
@atifaziz
Copy link
Owner Author

Closing this as I don't think it's an issue anymore. This must have been reported before the tokener was updated to parse quoted strings. Correct use would now be:

document.QuerySelectorAll("meta[property='og:url']")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant