Fix Windows #285
Fix Windows #285
Conversation
|
so that other linker error you saw is just optlink related so if the compiler is dmd, you need to specify either -m32mscoff OR -m64. not both, not neither. so i guess xor lol. but i'd say if args doesn't include -m64, just add -m32mscoff |
Fixes Error: argument expected for switch '-of'
|
This is ready now. I tested it on Windows by building a large C library, and I can confirm that now it works with d++ --mscrtlib=msvcrtd #....other things |
|
Edit: fixed in #287 I don't know why this irrelevant change somehow causes the Linux tests to fail in the CI! It works locally for me: Edit: This also happens on the master branch, so it is not related to this PR. |
| if(!dlangCompilerArgs.canFind!(a => a == "-m64" || a == "-m32" || a == "-m32mscoff")) { | ||
| version(X86_64) { | ||
| dlangCompilerArgs ~= "-m64"; | ||
| } | ||
| version(x86) { | ||
| dlangCompilerArgs ~= (dlangCompiler == "dmd") ? "-m32mscoff" : "-m32"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we run this code on all operating systems (except for the m32mscoff part)? Architecture is independent of Windows.
-of=to specify the outputAddresses #182 (comment)