Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigTrait _lookConfigElement throw error when request deep ref and not found #101

Closed
abbadon1334 opened this issue Jul 10, 2019 · 1 comment · Fixed by #106
Closed
Assignees

Comments

@abbadon1334
Copy link
Collaborator

if (!array_key_exists($el, $pos) && $create_elements) {

throw error : array_key_exists 2nd argument must be array

$this->config = [
'test' => 'something'
];

$this->getConfig('test/deep'); // <-- throw error

can we add a check if $pos is_array?

if(!is_array($pos))
{
return false;
}
@abbadon1334 abbadon1334 self-assigned this Jul 10, 2019
@romaninsh
Copy link
Member

sure why not...

DarkSide666 pushed a commit that referenced this issue Jul 15, 2019
* Fix case when ask for config path but not exists

* fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants