Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #101 case when ask for config path but not exists #106

Merged
merged 3 commits into from
Jul 15, 2019

Conversation

abbadon1334
Copy link
Collaborator

fix #101

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #106 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #106      +/-   ##
=============================================
+ Coverage      98.51%   98.51%   +<.01%     
- Complexity       325      326       +1     
=============================================
  Files             16       16              
  Lines            739      741       +2     
=============================================
+ Hits             728      730       +2     
  Misses            11       11
Impacted Files Coverage Δ Complexity Δ
src/ConfigTrait.php 100% <100%> (ø) 25 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c82c3...e0c4f25. Read the comment docs.

@DarkSide666 DarkSide666 merged commit 46a35d4 into atk4:develop Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigTrait _lookConfigElement throw error when request deep ref and not found
2 participants