Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill for PHP < 7.3 for array_key_first/last #172

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 22, 2020

To be used in ui & data, can be dropped once PHP 7.2 is no longer supported.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #172 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #172   +/-   ##
==========================================
  Coverage      97.03%   97.03%           
  Complexity       448      448           
==========================================
  Files             24       24           
  Lines           1046     1046           
==========================================
  Hits            1015     1015           
  Misses            31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48cee66...ba27345. Read the comment docs.

Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit e9a6668 into develop Apr 23, 2020
@mvorisek mvorisek deleted the mvorisek-patch-polyfill-array_key_first branch April 23, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants