Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSR class/trait/method naming #258

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Fix PSR class/trait/method naming #258

merged 1 commit into from
Jul 7, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jul 7, 2020

pure case refactor only, class/trait/method names are CI

renamed to pure PascalCase (camelCase for methods) with snake case reasoning (like you will never write h_t_m_l)

based on (?<!::)(trait|interface|function|class) ((?!(Expression|Connection|Query)_).)*[A-Z][A-Z]

the only breaking change is that these files will not load using autoloaded if not optimized and not using CI FS

updated names:

DIContainerTrait
atk4\core\ExceptionRenderer\HTML
atk4\core\ExceptionRenderer\JSON
Exception::getHTML()
Exception::getJSON()

for 100% BC you can require the renamed classes manually (but if some other updated code required them before use is enough)

@mvorisek
Copy link
Member Author

mvorisek commented Jul 7, 2020

@georgehristov ok with you, can you approve?

Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it follows agreed naming convention so your effort on this is appreciated!

@mvorisek mvorisek merged commit 3e269f4 into develop Jul 7, 2020
@mvorisek mvorisek deleted the norm_method_case branch July 7, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants