Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSR class/trait/method naming #1354

Merged
merged 11 commits into from
Jul 7, 2020
Merged

Fix PSR class/trait/method naming #1354

merged 11 commits into from
Jul 7, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jul 7, 2020

related with atk4/core#258

updated names:

View::getHTML()
View::renderJSON()
View::getJS()
Table\Column::getHTMLTags()
Callback::getURL()
Callback::getJSURL()
VirtualPage::getURL()
VirtualPage::getJSURL()
App::terminateHTML()
App::terminateJSON()
Table::getHeaderRowHTML()
Table::getTotalsRowHTML()
Table::getDataRowHTML()
Table\Column::getDataCellHTML()
Table\Column::getHeaderCellHTML()
Table\Column::getTotalsCellHTML()
App::getRequestURI() -> getRequestUrl()
App::renderExceptionHTML()
App::encodeHTML()
App::jsURL()
Console::outputHTML()
Tabs::addTabURL()
Text::addHTML()
Template::setHTML()
Template::trySetHTML()
Template::appendHTML()
Template::tryAppendHTML()
CRUD
App::requireCSS()
App::requireJS()
jsSSE
Persistence\UI
Persistence\POST
TabsSubView
DropDownButton
DropDown
BreadCrumb

jQuery
jUniv
jsCallback
jsChain
jsConditionalForm
jsExpressionable
jsExpression
jsFunction
jsModal
jsNotify
jsPaginator
jsReload
jsSearch
jsSortable
jsSse
jsToast
jsVueService

for 100% BC you can require the renamed classes manually (but if some other updated code required them before use is enough)

@mvorisek mvorisek force-pushed the norm_case branch 3 times, most recently from d3c7b49 to 3382153 Compare July 7, 2020 15:46
@mvorisek mvorisek marked this pull request as ready for review July 7, 2020 17:32
@mvorisek
Copy link
Member Author

mvorisek commented Jul 7, 2020

@georgehristov Is there any naming inconsistency in this PR/repo or other repo to address? Can you check quickly and/or do you have something in mind to change from past? Would be good if we can close these naming issues at now.

@mvorisek
Copy link
Member Author

mvorisek commented Jul 7, 2020

@ibelar what is the purpose of jUniv, is it used somewhere?

  • not used in ui
  • what is the univ.min.js file, something from past?

it is only a stub for autohinting, can/should we refactor code to use it or should we drop it?

@mvorisek mvorisek added the RTM label Jul 7, 2020
@mvorisek mvorisek merged commit 76c2056 into develop Jul 7, 2020
@mvorisek mvorisek deleted the norm_case branch July 7, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants