Use local resources only - pack/download from CDN lately on install

[mvorisek]

This is a feature request to pack or download all resources with composer at install/update.

This includes not only directly resources for atk4, but also for used libraries, like CDN fonts used in Fomantic UI.

Important for intranets/IOT where internet connection is not available or limited.

[DarkSide666]

(plus)+ already compiled JS and CSS files.

[mvorisek]

* already compiled JS and CSS files.

@DarkSide666, wdym? The compiled (& minified) files are currently not available within this repo.

One possible solution - and very common - is to put the compiled (& minified + possibly other downloaded resources) files into the repo directly, ensure that all of them can be built repeatably and add CI tests to make sure the compiled files are 1:1 (ie. synchronized) with the source files.

But at least the complete build script (that will also fetch the remote resources like Fomantic UI files) is needed.

[DarkSide666]

Well, sometimes it would be great to have compiled/minified files in repo.
They probably can be compiled automatically by some github action on each commit (or PR).

[romaninsh]

Are you suggesting to extend https://github.com/atk4/ui/blob/develop/tools/get-assets.php?

[mvorisek]

Are you suggesting to extend https://github.com/atk4/ui/blob/develop/tools/get-assets.php?

This is not enougt as the linked resources usually load/link fonts and other resources - see for ex. FUI css https://cdn.jsdelivr.net/npm/fomantic-ui@2.7.4/dist/semantic.min.css (and search for .woff)

[mvorisek]

There is no CDN solution when GH is down, resources must be committed within the repo (as we do with our CSS/JS) and checked by CI.

[mvorisek]

Should also fix Behat CI failures like:

Feature: Executor
  Testing basic action executor

  Scenario: basic                                   # tests-behat/basicexecutor.feature:4
    Given I am on "data-action/actions.php"         # Behat\MinkExtension\Context\MinkContext::visit()
    │
    ╳  Exception: jQuery did not finish within a time limit in src/Behat/Context.php:99
    ╳  Stack trace:
    ╳  #0 src/Behat/Context.php(62): Atk4\Ui\Behat\Context->jqueryWait()
    │
    └─ @AfterStep # Atk4\Ui\Behat\Context::waitUntilLoadingAndAnimationFinished()
    And I press button "Import"                     # Atk4\Ui\Behat\Context::iPressButton()
    Then Toast display should contains text "Done!" # Atk4\Ui\Behat\Context::toastDisplayShouldContainText()

[mvorisek]

Should also allow to customize SUI, see related issue #1257