Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow step executor args step to use a data model #1681

Open
ibelar opened this issue Oct 13, 2021 · 1 comment · May be fixed by #1687
Open

Allow step executor args step to use a data model #1681

ibelar opened this issue Oct 13, 2021 · 1 comment · May be fixed by #1687
Assignees

Comments

@ibelar
Copy link
Contributor

ibelar commented Oct 13, 2021

Make it possible to use a Data model in order to setup an action arguments.

Advantage:

  • args can be define as Model field;
  • args input can be validate using a model Validator;
@ibelar ibelar self-assigned this Oct 13, 2021
@ibelar ibelar linked a pull request Nov 4, 2021 that will close this issue
@mvorisek
Copy link
Member

Atk4/data UA must be improved to validate the $args againts the $ua->args definition (which needs also an improved phpdoc).

https://github.com/atk4/data/blob/06dc74732a/src/Model/UserAction.php#L144

Then these validations:

can be removed which are even wrong, as isset() will fail with null value like empty date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants