Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all array_merge_recursive usages #1811

Closed
mvorisek opened this issue Aug 4, 2022 · 2 comments · Fixed by #2149
Closed

Review all array_merge_recursive usages #1811

mvorisek opened this issue Aug 4, 2022 · 2 comments · Fixed by #2149

Comments

@mvorisek
Copy link
Member

mvorisek commented Aug 4, 2022 •
edited
Loading

array_merge_recursive can merge the data not as expected, review all usages in this repo. All other major repos has no use, thus fine.

related with atk4/data#1046
@mvorisek
Copy link
Member Author

one use also in https://github.com/atk4/chart/blob/4866a37172667b244055d1813da88bb8ca1fd3e5/src/Chart.php#L91

atk4/chart should use also camelCase everywhere

@mvorisek
Copy link
Member Author

mvorisek commented Aug 27, 2022 •
edited
Loading

also array_replace_recursive, regex array\w+recursive

@mvorisek mvorisek mentioned this issue Sep 28, 2022
Merged
3 tasks
@mvorisek mvorisek mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor table columns improvements atk4/ui
1 participant
@mvorisek