Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crud or CardDeck add/edit modals not scrollable on first show #1909

Closed
mkrecek234 opened this issue Oct 19, 2022 · 3 comments
Closed

Crud or CardDeck add/edit modals not scrollable on first show #1909

mkrecek234 opened this issue Oct 19, 2022 · 3 comments
Labels

Comments

@mkrecek234
Copy link
Contributor

  • I have a Crud or CardDeck with a set model with many fields, so the add or edit form is larger/longer than the screen
  • If I click on add or edit after page load the first time, it shows the "middle" of the form, the top header is missing. The modal is not scrollable.
  • If I close the modal, and click add again, it shows correct and is scrollable.

image

@mvorisek
Copy link
Member

thank you for the report - that is fomantic/Fomantic-UI#2476

In #1903 I removed unneeded refreshes as much as possible in favor of observeChanges set for all modals, it should be enough if the modal content is replaced with some added/removed HTML nodes (as attribute changes are currently not observed by Fomantic-UI)

in demos/collection/card-deck.php demo I cannot reproduce it - can you?

please also make sure you load the latest js files, press ctrl+f5 in your browser or clear cache

ideally find some demo on which you can reproduce, or please put together a minimalistic code to reproduce, I can then fix quickly

@mkrecek234
Copy link
Contributor Author

Replacing JS files and refreshing cache solved the issue already. Thank you!

@mvorisek
Copy link
Member

Thank you for the feedback ❤️

Replacing JS files

several months ago I fixed all CDN problems by versioning the JS files together with the atk4/ui - please always link the files to the atk4/ui/public dir and never copy them somewhere else, no manual replacing should be done

refreshing cache

currently we do not serve the static files thru PHP/VirtualPage and the cache control from atk4/ui side is limitted

webserver configured to allow caching and requring the client to check with modified date or hash tag solves this issue, but a lot of webservers are configured to send files with headers with more aggressive caching... I am aware of this problem, to be fixed someday...

@mvorisek mvorisek removed their assignment Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants