Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterModel bug with in 5.2 release #2210

Closed
mkrecek234 opened this issue Jun 17, 2024 · 1 comment · Fixed by #2211
Closed

FilterModel bug with in 5.2 release #2210

mkrecek234 opened this issue Jun 17, 2024 · 1 comment · Fixed by #2211
Labels
bug 🪲

Comments

@mkrecek234
Copy link
Contributor

Simple bug, but unfortunately GitHub won't let me create a new branch anymore, so here in quick words:

  • Create grid with $grid->addFilterColumn() where one of the columns is a bigint ID.
  • FilterModel

    ui/src/Table/Column/FilterModel.php

    Line 52 in 12b9e3d

    $class = [
    misses the bigint type assignment and thus it throws an error.

Just add

            Types::INTEGER => FilterModel\TypeNumber::class,

to $class array and all works fine again.
@mkrecek234
Copy link
Contributor Author

See fix in #2211

@mvorisek mvorisek mentioned this issue Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "smallint" and "bigint" support to FilterModel mkrecek234/ui
1 participant
@mkrecek234