Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Custom Form Layout, Lookup FormField has an empty <label> tag #663

Closed
PhilippGrashoff opened this issue Feb 25, 2019 · 5 comments
Closed

On Custom Form Layout, Lookup FormField has an empty <label> tag #663

PhilippGrashoff opened this issue Feb 25, 2019 · 5 comments
Assignees
@ibelar @PhilippGrashoff
Labels
bug 🪲

Comments

@PhilippGrashoff
Copy link
Collaborator

Normally, input fields in Custom Form Layout do not have a tag. However, the lookup formfield has an empty tag in a custom form layout.
@romaninsh
Copy link
Member

Could you provide some screneshot or test-code?

@PhilippGrashoff
Copy link
Collaborator Author

label_on_lookup
The 2 fields with extra indent come from hasOne(), hence Lookup FormField is used now.

ibelar added a commit that referenced this issue Mar 4, 2019
@ibelar
fix/Lookup Autocomplete fix
5696ea4 
Fixes #656, #663, #664
@ibelar ibelar mentioned this issue Mar 4, 2019
Merged
@ibelar
Copy link
Contributor

ibelar commented Mar 4, 2019

Fix in #671

DarkSide666 pushed a commit that referenced this issue Mar 5, 2019
@ibelar @DarkSide666
fix/Lookup Autocomplete fixes (#671)
b977d10 
* fix/Lookup Autocomplete fix

Fixes #656, #663, #664

* Apply fixes from StyleCI

* fix typo
@DarkSide666
Copy link
Member

@PhilippGrashoff can you confirm that this is fixed now?

@romaninsh
Copy link
Member

re-open if not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibelar ibelar

@PhilippGrashoff PhilippGrashoff

Labels
bug 🪲
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@romaninsh @DarkSide666 @ibelar @PhilippGrashoff