Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Lookup Autocomplete fixes #671

Merged
merged 4 commits into from
Mar 5, 2019
Merged

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Mar 4, 2019

Various fix for Lookup and Autocomplete field

Fixes #656, #663, #664

  • Keep previous select value;
  • Proper width apply when used in group;
  • Remove empty filter label

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #671 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #671      +/-   ##
=============================================
+ Coverage      72.74%   72.76%   +0.01%     
  Complexity      1869     1869              
=============================================
  Files            102      102              
  Lines           4418     4421       +3     
=============================================
+ Hits            3214     3217       +3     
  Misses          1204     1204
Impacted Files Coverage Δ Complexity Δ
src/FormField/AutoComplete.php 65.95% <100%> (+0.36%) 33 <0> (ø) ⬇️
src/FormField/Lookup.php 76.79% <100%> (+0.25%) 55 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3208b13...cdd070e. Read the comment docs.

@ibelar ibelar changed the title fix/Lookup Autocomplete fix fix/Lookup Autocomplete fixes Mar 4, 2019
@FabulousGee
Copy link
Contributor

Fix for #656 confirmed.

@DarkSide666 DarkSide666 self-requested a review March 5, 2019 13:37
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@DarkSide666 DarkSide666 merged commit b977d10 into develop Mar 5, 2019
@DarkSide666 DarkSide666 deleted the fix/autocomplete-lookup branch March 5, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width is not applied correctly to elements
4 participants