Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixed names in tests #1243

Closed
wants to merge 1 commit into from
Closed

Fix fixed names in tests #1243

wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 5, 2020

Proper fix for:
image

related with atk4/core#225

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1243 into develop will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1243      +/-   ##
=============================================
- Coverage      72.83%   72.74%   -0.10%     
  Complexity      2557     2557              
=============================================
  Files            130      130              
  Lines           6270     6270              
=============================================
- Hits            4567     4561       -6     
- Misses          1703     1709       +6     
Impacted Files Coverage Δ Complexity Δ
src/Console.php 78.10% <0.00%> (-4.38%) 46.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59506b...07c49a3. Read the comment docs.

@mvorisek
Copy link
Member Author

mvorisek commented Jun 5, 2020

replaced by #1245

@mvorisek mvorisek closed this Jun 5, 2020
@mvorisek mvorisek deleted the fix_test__new_names branch June 5, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant