Fix tests - do not rely on hardcoded/expected names #1245
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1245 +/- ##
=============================================
- Coverage 72.27% 70.62% -1.65%
- Complexity 2555 2560 +5
=============================================
Files 130 130
Lines 6315 6319 +4
=============================================
- Hits 4564 4463 -101
- Misses 1751 1856 +105
Continue to review full report at Codecov.
|
…ix/unit-test-url
Will confirm all works
|
Revert this to draft - I forgot to add behat test for basic action executor |
mvorisek
changed the title
mvorisek
force-pushed
the
fix/unit-test-url
branch
from
f344249
to
75f2738
Compare
mvorisek
force-pushed
the
fix/unit-test-url
branch
3 times, most recently
from
e0747b5
to
fdda7a3
Compare
There was a problem hiding this comment.
Not yes fully compatible with differently generated names:
clone this PR, run composer install and edit vendor/core/src/TrackableTrait.php like in the screen to retest, ideally fot Behat as well
PHPUnit 9.2.1 by Sebastian Bergmann and contributors.
Runtime: PHP 7.4.5
Configuration: dequ\ui\phpunit.xml.dist
............................................................... 63 / 317 ( 19%)
............................................................... 126 / 317 ( 39%)
............................................................... 189 / 317 ( 59%)
...............F.................................F.F........FFF 252 / 317 ( 79%)
...FF.......................................................... 315 / 317 ( 99%)
.. 317 / 317 (100%)
Time: 01:34.739, Memory: 10.00 MB
There were 8 failures:
1) atk4\ui\tests\GridTest::test2
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<td>{$email}</td><td><a href="#" title="Delete {$email}?" class="delete"><i class="ui red trash icon"></i>Delete</a></td>'
+'<td>{$email}</td><td><a href="#" title="Delete {$email}?" class="deletex"><i class="ui red trash icon"></i>Delete</a></td>'
dequ\ui\tests\GridTest.php:63
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
2) atk4\ui\tests\TableColumnColorRatingTest::testValueGreaterThanMax
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<td>{$name}</td><td>{$ref}</td><td style="{$_colorrating_color_rating}">{$rating}</td>'
+'<td>{$name}</td><td>{$ref}</td><td style="{$_colorratingx_color_rating}">{$rating}</td>'
dequ\ui\tests\TableColumnColorRatingTest.php:59
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
3) atk4\ui\tests\TableColumnColorRatingTest::testValueLowerThanMin
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<td>{$name}</td><td>{$ref}</td><td style="{$_colorrating_color_rating}">{$rating}</td>'
+'<td>{$name}</td><td>{$ref}</td><td style="{$_colorratingx_color_rating}">{$rating}</td>'
dequ\ui\tests\TableColumnColorRatingTest.php:109
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
4) atk4\ui\tests\TableColumnLinkTest::testTDLast
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<td>{$name}</td><td>{$ref}</td><td class="{$_money_class} right aligned single line">{$salary}</td>'
+'<td>{$name}</td><td>{$ref}</td><td class="{$_moneyx_class} right aligned single line">{$salary}</td>'
dequ\ui\tests\TableColumnLinkTest.php:56
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
+'<td class="{$_moneyx_class} right aligned single line">{$name}</td><td>{$ref}</td><td class="{$_moneyx_2_class} right aligned single line"><b>{$salary}</b></td>'
dequ\ui\tests\TableColumnLinkTest.php:89
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
7) atk4\ui\tests\TableColumnLinkTest::testLink1
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<td><a href="{$c_link}">{$name}</a></td><td>{$ref}</td>'
+'<td><a href="{$c_linkx}">{$name}</a></td><td>{$ref}</td>'
dequ\ui\tests\TableColumnLinkTest.php:149
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
8) atk4\ui\tests\TableColumnLinkTest::testLink1a
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<td><a href="{$c_link}">{$name}</a></td><td>{$ref}</td>'
+'<td><a href="{$c_linkx}">{$name}</a></td><td>{$ref}</td>'
dequ\ui\tests\TableColumnLinkTest.php:164
dequ\ui\vendor\atk4\core\src\AtkPhpunit\TestCase.php:17
FAILURES!
Tests: 317, Assertions: 1029, Failures: 8.
All right. Done! |
just realized we had a trait file for table test.
also fix quicksearch stickyGet
mvorisek
force-pushed
the
fix/unit-test-url
branch
2 times, most recently
from
69cc7aa
to
4f8d19a
Compare
mvorisek
force-pushed
the
fix/unit-test-url
branch
from
4f8d19a
to
30ca774
Compare
| * | ||
| * @param $arg1 | ||
| */ | ||
| public function iWait($arg1) | ||
| public function iSleep($arg1) |
There was a problem hiding this comment.
Well, in Behat feature step, it should represent a user action interacting with the browser. A user would rather 'wait' then 'sleep' before doing another action.
There was a problem hiding this comment.
I kept all other (non-dummy) waits. But as dummy wait() (without test function) is a sleep (correct me if I am wrong), then sleep is much more self explaining.
There was a problem hiding this comment.
You may have to wait until dom element finishes transitioning, but you only know visually, but as a user, you are still waiting not falling asleep. ;)
There was a problem hiding this comment.
;) then, now it is much clearer if a user sleep for a fixed TIME or wait (ie. with fixed TIMEOUT, but TIME can be shorter) for something.
I retested this PR and all fixed names are solved. Great work! Can we merge or do you have more ideas to add?
There was a problem hiding this comment.
Well, if you sleep in front of your computer, you might have a very boring app in front of you. :-) Go ahead, we can merge.
mvorisek
force-pushed
the
fix/unit-test-url
branch
from
9ee11a2
to
8c03449
Compare
| @@ -22,7 +24,7 @@ public function __construct() | |||
| /** @var null Temporary store button id when press. Use in js callback test. */ | |||
| protected $buttonId; | |||
|
|
|||
| public function getSession($name = null): Behat\Mink\Session | |||
| public function getSession($name = null): \Behat\Mink\Session | |||
There was a problem hiding this comment.
Exactly for this I added NS - for consistent CS
merge after: #1251
Set URL used in some unit testing file manually so they become independent of class naming.
Update unit test for certain test in order to make their test URL independent of the class name structure convention that usually applies with Callbacks uses in Modal, Loader, jsSSE, Form, or jsReload.