Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #224 (fix for ui tests/fixed names) #225

Merged
merged 1 commit into from Jun 11, 2020
Merged

Revert #224 (fix for ui tests/fixed names) #225

merged 1 commit into from Jun 11, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 5, 2020 •
edited

merge after atk4/ui#1245 and atk4/ui#1252

@mvorisek mvorisek mentioned this pull request Jun 5, 2020
Closed
@mvorisek mvorisek changed the title Revert "Temporary fix for ui tests - try to produce the same component names as before #220" Revert fix for ui tests - try to produce the same component names as before #220 Jun 5, 2020
@mvorisek mvorisek changed the title Revert fix for ui tests - try to produce the same component names as before #220 Revert #225 (fix for ui tests) Jun 5, 2020
@mvorisek mvorisek changed the title Revert #225 (fix for ui tests) Revert #224 (fix for ui tests) Jun 5, 2020
@mvorisek mvorisek changed the title Revert #224 (fix for ui tests) Revert #224 (fix for ui tests/fixed names) Jun 5, 2020
@atk4 atk4 deleted a comment from codecov bot Jun 6, 2020
@mvorisek mvorisek added the RTM label Jun 7, 2020
romaninsh
romaninsh approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 58f0f2e into develop Jun 11, 2020
@mvorisek mvorisek deleted the revert-224-tmp_fix_for_ui__names branch June 11, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @romaninsh