New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of hasXXX(), it now return bool only #1252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$row->get($field)
should also work even if $field
is a \atk4\data\Field
. Any reason to change this?
@georgehristov |
I really don't like the direction of stripping down the versatility... |
I may seem so - but compare how many uses are "correct/canonical" and how many are like to be fixed - it is more than 100:1. Without the data, I would say probably the say the same as you... Let's get this merged. If you prefer array access like model access, getting values by field objects, you made extend the data Model and use it within your projects as you like. But in lib, we need more standardized types and workflows, so everyone can understand it and the hidden bugs are discovered (for ex. mixed types of "current_row" and more than 10 others issues). |
in future,
hasField
might be introduced back but to return strictly bool value as expected, but it is no BC break now and will not be later -tryGetField
will remain