Small normalization changes #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious, why do we need periodic testing anyway? https://github.com/atk4/ui/pull/1128/files#diff-4794c8638bc5e5ec555e780ee618f61fR8 IMHO testing triggered by merge/push should be sufficient. |
|
Mainly to update the tests if any parent dependency is changed. And core and data is changing a lot. There should be no BC breaks in theory, but in reality there are, and this can let everyone know further action is needed. Makes sense? |
|
OK - lets give it a try. |
georgehristov
approved these changes
Jun 12, 2020
because #1252 - please approve if possible |
|
It is approved already |
#1252 is waiting to be approved |
georgehristov
approved these changes
Jun 12, 2020
georgehristov
approved these changes
Jun 12, 2020
georgehristov
approved these changes
Jun 12, 2020
georgehristov
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.