Fix app/owner getters #1474
Merged
Fix app/owner getters #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_app_owner_getters
branch
2 times, most recently
from
192d542
to
dac1677
Compare
mvorisek
force-pushed
the
fix_app_owner_getters
branch
3 times, most recently
from
334ffd7
to
a16a822
Compare
mvorisek
force-pushed
the
fix_app_owner_getters
branch
3 times, most recently
from
0343e87
to
c660f6e
Compare
mvorisek
force-pushed
the
fix_app_owner_getters
branch
3 times, most recently
from
5d302bc
to
c1d9b7e
Compare
|
@romaninsh please approve this as well |
DarkSide666
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for atk4/core#277
as getApp and/or getOwner assert not null, this also highly improve error trace and allow assumptions if not nullable