Move "app" and "owner" props to getter/setter

[mvorisek]

there are at least 3 reasons why:

• have more control (type check, reassign, enforce presence in some situations like after init, ...)
• allow to use WeakReference (for owner to allow to release child object based on ref counting not requiring expensive/slow GC)
• make sure we do not get/set properties on object not "implementing" given traits

if AppScopeTrait trait is present, we may even want to assert if App is set in any init

How to update your code?

1. replace ->owner-> with ->getOwner()->
2. search for ->owner(?!\w) and adjust to getOwner(), setOwner(), issetOwner() manually
3. do the same with app property

[mvorisek]

because of trait design, private prop will still be accessible from the class where used

we may want to rename to _app, but then any assigment will not throw - but it can be solved by checking ->app inside init or in the getter/setter methods in this trait

[mvorisek]

impossible to test if there is no App class - do we want this trait really in core? If yes, we can enforce object type and phpdoc App.

[mvorisek]

@georgehristov PRs for all major repos are done, ok to merge?

[romaninsh]

can this be backward compatible for 1 major release?

[mvorisek]

can this be backward compatible for 1 major release?

no, as it would require magic properties almost in every object

the good new is, that existing code can be migrated almost completely with "ctrl+h"

[romaninsh]

@mvorisek I'd love if we avoid this. I mean you could add a dummy getOwner() that returns $this->owner for entire release for backward compatibility. Can we have that for 2.3 so that users could start updating code before migrating?

[romaninsh]

OK, but please add compatibility into 2.3 release branch.