-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong bottom bar height #3244
Comments
Tried (define-configuration status-buffer
((height 40))) and got
|
Thanks for reporting. #3170 addresses this issue. @jmercouris, friendly ping on reviewing the PR. |
hi there i am having same issue on my laptop using X11 and scaling issues cause similar ui problem @jmercouris please have a look at the PR if it resolve this issue thanks :) |
I, too, am experiencing this same issue on versions 3.9.0 and 3.9.1. I'm also on Arch. |
Sorry for the problem, I'll look at it hopefully on Monday :-) |
I have mentioned that #3170 addresses this issue but, on second thoughts, I don't think that's the case. @ST-Saint, @apsinthium can you reproduce the issue when starting Nyxt via @Aneeqasif are you also on Arch? I can't reproduce the issue on Guix or Flatpak. It could be related to the fact that you're running WebKitGTK 2.42.1 on Arch, while both Flatpak and Guix are still using previous versions. |
@aadcg I can reproduce with all three of the suggestions you listed. |
@apsinthium thanks! I'm afraid I'll have to wait until I'm able to reproduce the issue. I remind that only the Flatpak and Guix are official means of distributions curated by the team, which explains why this issue escaped the radar. |
Updating to note that this also happens with the flatpak version on Arch. |
@apsinthium that's really surprising. I can't reproduce it with flatpak. Can you run |
@aadcg The flatpak was already up-to-date, but I ran the update check anyway.
|
@apsinthium I've asked to run Apart from the fact that we're running different Linux kernel versions, I'm inclined to think that this might be due to graphics. Which window manager or desktop environment are you running? Xorg or Wayland? What's the output of |
@aadcg My apologies. I don't use Flatpak anymore, so I had just installed it and it was the latest version. However, I ran the command again just to double-check. There were no updates for Flatpak itself. I am running i3-wm on Xorg. There was no output for the requested command. |
Thanks again @apsinthium! @jmercouris can you reproduce it on Flatpak? |
Yes, I can:
|
I think the issue is this one: #1388 |
@jmercouris, I see. I thought no one was using @apsinthium does starting via |
@aadcg Unfortunately, I uninstalled Flatpak since I still had the issue there. However, running the commands you listed for the arch package still has the same issue. I do have to scale my screen because I have a high resolution display and everything is too tiny to see if I do not. Strangely, I didn't have this issue before 3.9.0. |
@apsinthium thanks for the feedback. Things start to make sense then. It doesn't seems directly related to Nyxt, while it is true that the UI should handle arbitrary display settings (hence #3170). I think that probably Arch updated some dependency library and the same display config now results in a different behavior. I.e. it is not related to the release of 3.9.0. It would be great if you could tell me exactly what display config is responsible for this issue. Also, could you try to run Nyxt from master? I believe that Arch provided such a package. Does it solve this issue? Thanks. |
Here's my
And my
Let me know if you need more information or if this isn't what you wanted.
I only see one package in the Arch repository. How would I go about running Nyxt from master? |
My understanding is that GTK started treating this piece of config differently for some unknown reason. I expect that you'd set it to 96 and then start Nyxt via
I don't know much about Arch, but my understanding is that installing this package would install Nyxt from the tip of the master branch - https://aur.archlinux.org/packages/nyxt-git. |
@aadcg The |
I don't think any further steps should be taken from our our side to mitigate this issue as of today. Maybe we could ignore custom
This is not related to Nyxt, but rather a piece of advice. For Qt and GTK apps, you may consider setting |
This is not only an arch issue as I'm having the same problem on nixos. |
@idrisr do you also set |
Yes, I set |
@idrisr although this has nothing to do with Nyxt, I repeat the advice I shared above
If you're able to compile from master, you could test it. @apsinthium reported but it fixes the issue, but not completely. The font size will likely still look off. |
Just a question: why do other Qt/GTK apps scale properly without running the |
@apsinthium I think that you're asking the right question. What is a complete mystery to me is that, as far as I understand, you were always setting the DPI to a value higher than 96 and the status buffer was properly rendered. Then you observed the issue and assumed that it was related to an updated Nyxt version. Is that so? |
Yes, I was.
As I remember, the status bar was fine prior to 2.9.0. But, as I said, other Qt applications such as QtBrowser and Gqrx render properly. I don't use many GTK applications anymore, but GIMP and gThumb both have correct font sizes. That's the only reason I attributed it to an update. |
I think I will try to reproduce with different versions. Perhaps the CSS changes I made from em to px are considered in GTK sizing. |
@jmercouris I remind you that commit 5cd7bee, to which I think you're referring to, has never landed on any of the 3-series releases. In other words, it is completely unrelated. If you mean that you'd like to tweak the CSS of the status buffer such that |
I did mean that commit, yes. In that case, I have no more ideas. Will investigate later. This is not a high priority for me right now. |
I'll backport the changes from PR #3170 to mitigate this issue in the next 3-series release. The issue will persist nonetheless. Not a priority at the moment. |
Also observed on openSUSE TW with Nyxt 3.9.2, resulting in a slight cut similar to the screenshot in #3244 (comment). Using:
|
EDIT: with |
Why do you need to set I think you should either the first one alone, or the third one alone. |
Because on my laptop panel screen (4K at 17.3") I need system-wide font scaling at 2.5x for them be comfortable to read (they are slightly too small at 2x). That panel physical dpi is 253 ppi and I opted for 240 as it correspond to 2.5x scaling which result in fonts whose size is very close to what they would be on a 1080p panel of the same size with no scaling. |
Also |
Release 3.10.0 may mitigate this issue. |
Confirming it fixes it on my system. |
Please re-open in case the issue persists. Thanks. |
Just noting that the issue still persists on Arch. |
Are you running the latest version on Arch? With the fix applied? |
@jmercouris I'm on version 3.10.0 which was released in the Arch repository yesterday, so I believe it is the latest version. |
Interesting. Let's try to understand what differs in the setup of @bubbleguuum and @apsinthium. Both set To gather more information, share a screenshot of how the status buffer looks like when starting nyxt 3.10.0 via |
Note that I get correct scaling with |
@bubbleguuum's settings definitely look better on my screen. Again, the only reason I bring this to attention is none of my other GTK apps require starting this way so perhaps, one day, we could get to place where scaling is performed at automatically by Nyxt? |
Update: apologies, I forgot the issue at hand was the bottom bar being cut off/cutting off the input. The bar is positioned correctly. My issue is about scaling which is another topic. Sorry about that! |
I understand your point and agree - this would certainly be desirable. Right now, given the amount of more pressing issues, I find that fiddling with these GTK env variables is good enough. Thanks for understanding. If someone knows how to fix it in a more robust way, PRs are certainly welcomed! |
Describe the bug
The bottom bar height doesn't match the font size somehow.
Information
show-system-information
:Output when started from a shell
Nyxt version: 3.9.0
Renderer: GI-GTK
Operating system kernel: Linux 6.5.9-arch2-1
Lisp implementation: SBCL 2.3.8 (Dynamic space size: 3221225472)
Features: (:NYXT-GI-GTK :NYXT-GTK :NYXT-GI-GTK :NYXT-GTK :NYXT-3.9 :NYXT-3 :NYXT-3.9.0 :CLIPBOARD-CONTENT-METHOD :SWANK :SLYNK :PLUMP-UTF-32 :PARENSCRIPT :NSYMBOLS :FSET-EXT-STRINGS :SBCL+SAFE-STANDARD-READTABLE :NAMED-READTABLES :GLOBAL-VARS :CL-FAD :LPARALLEL :21BIT-CHARS :CUSTOM-HASH-TABLE-NATIVE :CL-PPCRE-UNICODE :CL-UNICODE :CL-JSON-DOUBLE-FLOAT-IS-SUBSUMED :CL-JSON-SINGLE-FLOAT-IS-SUBSUMED :CHUNGA :FLEXI-STREAMS :CL-PPCRE :WEBKIT2 :WEBKIT-2.42.1 :WEBKIT-2.42 :WEBKIT-2 :WEBKIT2-CORS-ALLOWLIST :WEBKIT2-PASTE-PLAINTEXT :WEBKIT2-TRACKING :WEBKIT2-MUTE :WEBKIT2-EMOJI :WEBKIT2-MEDIA :WEBKIT2-SANDBOXING :GTK-3-22 :GTK-3-20 :GTK-3-18 :GTK-3-16 :GTK-3-14 :GTK-3-12 :GTK-3-10 :GTK-3-8 :GTK-3-6 :GTK-3-4 :GTK :GDK-3-22 :GDK-3-20 :GDK-3-18 :GDK-3-16 :GDK-3-14 :GDK-3-12 :GDK-3-10 :GDK-3-8 :GDK-3-6 :GDK-3-4 :CAIRO-1-10 :CAIRO-1-12 :GDK-PIXBUF :CLOSER-MOP :GLIB-2-30 :GLIB-2-32 :GLIB-2-34 :GLIB-2-36 :GLIB-2-38 :GLIB-2-40 :GLIB-2-42 :GLIB-2-44 :GLIB-2-46 :GLIB-2-48 :GLIB-2-50 :GLIB-2-52 :GLIB-2-54 :GLIB-2-56 :GLIB-2-58 :GLIB :BORDEAUX-THREADS :LPARALLEL.WITH-CLTL2 :LPARALLEL.WITH-CAS :LPARALLEL.WITH-STEALING-SCHEDULER :SPLIT-SEQUENCE CFFI-FEATURES:FLAT-NAMESPACE CFFI-FEATURES:X86-64 CFFI-FEATURES:UNIX :CFFI CFFI-SYS::FLAT-NAMESPACE ALEXANDRIA::SEQUENCE-EMPTYP :FAST-IO-SV :FAST-IO :CL-JSON-CLOS :CL-JSON :SBCL-USES-SB-ROTATE-BYTE CHIPZ-SYSTEM:GRAY-STREAMS :THREAD-SUPPORT :ASDF3.3 :ASDF3.2 :ASDF3.1 :ASDF3 :ASDF2 :ASDF :OS-UNIX :NON-BASE-CHARS-EXIST-P :ASDF-UNICODE :ARENA-ALLOCATOR :X86-64 :GENCGC :64-BIT :ANSI-CL :COMMON-LISP :ELF :IEEE-FLOATING-POINT :LINUX :LITTLE-ENDIAN :PACKAGE-LOCAL-NICKNAMES :SB-CORE-COMPRESSION :SB-LDB :SB-PACKAGE-LOCKS :SB-THREAD :SB-UNICODE :SBCL :UNIX)
ASDF version: 3.3.1
ASDF registries: (NYXT-SOURCE-REGISTRY ENVIRONMENT-SOURCE-REGISTRY)
Critical dependencies: (/build/nyxt/src/_build/cl-cffi-gtk/gtk/cl-cffi-gtk.asd /build/nyxt/src/_build/cl-gobject-introspection/cl-gobject-introspection.asd /build/nyxt/src/_build/cl-webkit/webkit2/cl-webkit2.asd)
The text was updated successfully, but these errors were encountered: