Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(setf height) method for message and status buffers and fix CSS for scaling #3170

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Sep 15, 2023

Description

Minor improvement.

Checklist:

Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.

  • Git hygiene:
    • I have pulled from master before submitting this PR
    • There are no merge conflicts.
  • I've added the new dependencies as:
    • ASDF dependencies,
    • Git submodules,
      cd /path/to/nyxt/checkout
      git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser
    • and Guix dependencies.
  • My code follows the style guidelines for Common Lisp code. See:
  • I have performed a self-review of my own code.
  • My code has been reviewed by at least one peer. (The peer review to approve a PR counts. The reviewer must download and test the code.)
  • Documentation:
    • All my code has docstrings and :documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)
    • I have updated the existing documentation to match my changes.
    • I have commented my code in hard-to-understand areas.
    • I have updated the changelog.lisp with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).
      • Changelog update should be a separate commit.
    • I have added a migration.lisp entry for all compatibility-breaking changes.
    • (If this changes something about the features showcased on Nyxt website) I have these changes described in the new/existing article at Nyxt website or will notify one of maintainters to do so.
  • Compilation and tests:
    • My changes generate no new warnings.
    • I have added tests that prove my fix is effective or that my feature works. (If possible.)
    • I ran the tests locally ((asdf:test-system :nyxt) and (asdf:test-system :nyxt/gi-gtk)) and they pass.

@aadcg aadcg force-pushed the minor-status-message-buffer-fix branch from 8091688 to bb3f173 Compare September 15, 2023 14:31
@aadcg
Copy link
Member Author

aadcg commented Sep 15, 2023

I don't understand the error that CCL raises. Any idea? CC @aartaka.

@jmercouris
Copy link
Member

CCL is naught but a thorn in my side!

@aadcg aadcg force-pushed the minor-status-message-buffer-fix branch from bb3f173 to 7e3c4ef Compare October 6, 2023 12:20
@aadcg
Copy link
Member Author

aadcg commented Oct 6, 2023

The issue had nothing to do with CCL, but it's fixed now.

The info below summarizes the PR.


Message buffer

Scaling works well.

message-buffer-scalling.mp4

Status buffer

Scaling doesn't work so well. @jmercouris I think you'd be more comfortable to adjust the CSS here.

simplescreenrecorder-2023-10-06_15.16.52.mp4

@aadcg aadcg changed the title Minor status message buffer fix `(setf height Oct 6, 2023
@aadcg aadcg changed the title `(setf height (setf height) method for message and status buffers and fix CSS for scaling Oct 6, 2023
@aadcg
Copy link
Member Author

aadcg commented Oct 16, 2023

@jmercouris friendly ping.

@aadcg aadcg mentioned this pull request Oct 20, 2023
4 tasks
@aadcg aadcg mentioned this pull request Oct 28, 2023
@jmercouris
Copy link
Member

It is on my TODO list now!

@jmercouris
Copy link
Member

These SVGs are driving me crazy, but I am working on it.

@jmercouris
Copy link
Member

I did manage to fix the CSS. I had to set the aspect ratio of the control buttons, set the display to flex for the container, and then set the height of the control buttons to 100%.

aadcg and others added 5 commits November 1, 2023 21:02
Impacts the call (public-initargs 'prompt-buffer), in %prompt-args.
The font size is set according to the height of the message buffer.
Dynamically resize according to height.
@aadcg aadcg force-pushed the minor-status-message-buffer-fix branch from 812cca7 to f0e3815 Compare November 1, 2023 19:31
@aadcg
Copy link
Member Author

aadcg commented Nov 1, 2023

@jmercouris great work, thanks!

Minor remark: always rebase when picking up on previously started work. There's no guarantee that another rebase won't be needed before merging, but it helps the reviewer nonetheless.

@aadcg aadcg merged commit b072935 into master Nov 1, 2023
2 checks passed
@aadcg aadcg deleted the minor-status-message-buffer-fix branch November 1, 2023 19:46
aadcg added a commit that referenced this pull request Dec 4, 2023
Backport changes from PR #3170.

Mitigate #3244.
aadcg added a commit that referenced this pull request Dec 11, 2023
Backport changes from PR #3170.

Mitigate #3244.
aadcg added a commit that referenced this pull request Dec 11, 2023
Backport changes from PR #3170.

Mitigate #3244.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants