-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(setf height)
method for message and status buffers and fix CSS for scaling
#3170
Conversation
8091688
to
bb3f173
Compare
I don't understand the error that CCL raises. Any idea? CC @aartaka. |
CCL is naught but a thorn in my side! |
bb3f173
to
7e3c4ef
Compare
The issue had nothing to do with CCL, but it's fixed now. The info below summarizes the PR. Message bufferScaling works well. message-buffer-scalling.mp4Status bufferScaling doesn't work so well. @jmercouris I think you'd be more comfortable to adjust the CSS here. simplescreenrecorder-2023-10-06_15.16.52.mp4 |
(setf height)
method for message and status buffers and fix CSS for scaling
@jmercouris friendly ping. |
It is on my TODO list now! |
These SVGs are driving me crazy, but I am working on it. |
I did manage to fix the CSS. I had to set the aspect ratio of the control buttons, set the display to flex for the container, and then set the height of the control buttons to 100%. |
Impacts the call (public-initargs 'prompt-buffer), in %prompt-args.
The font size is set according to the height of the message buffer.
Dynamically resize according to height.
812cca7
to
f0e3815
Compare
@jmercouris great work, thanks! Minor remark: always rebase when picking up on previously started work. There's no guarantee that another rebase won't be needed before merging, but it helps the reviewer nonetheless. |
Description
Minor improvement.
Checklist:
Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.
cd /path/to/nyxt/checkout git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser
:documentation
s written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)changelog.lisp
with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).migration.lisp
entry for all compatibility-breaking changes.(asdf:test-system :nyxt)
and(asdf:test-system :nyxt/gi-gtk)
) and they pass.