Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joinWith doesn't work when specifying direction #102

Closed
sunkan opened this issue Jan 21, 2019 · 0 comments
Closed

joinWith doesn't work when specifying direction #102

sunkan opened this issue Jan 21, 2019 · 0 comments

Comments

@sunkan
Copy link
Contributor

sunkan commented Jan 21, 2019

Hi

When doing a joinWith('LEFT JOIN relationship') it will crash with Undefined index: JOIN relationship

The problem is in MapperRelationships::joinSelect on line 297 when removing the join part it don't include the length of JOIN

I'll try to put together a pull request later today.
@sunkan sunkan closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunkan