Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

Add missing dependencies for golangci-lint #55

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Add missing dependencies for golangci-lint #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
603629b
Add missing dependencies for golangci-lint
ash2k Mar 28, 2019
864fde1
Run buildifier
ash2k Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions golangcilint/def.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ def _golangcilint_impl(ctx):
transitive_depsets = [
depset(sdk.srcs),
depset(sdk.tools),
depset(sdk.libs),
depset([sdk.go]),
]
default_runfiles = ctx.attr._golangcilint[DefaultInfo].default_runfiles
if default_runfiles != None:
Expand Down
16 changes: 8 additions & 8 deletions golangcilint/deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ _PREFIX = (

_VERSION = "1.14.0"
_CHECKSUMS = {
"windows-386": "d819336b57a61c2676fb99352fead8aa567b454202e22670eec5833b04eb3a78",
"windows-amd64": "e79cbe016591832b85ce66f29c8180ebd8a45dcb793a44c9d3ff101bd7f3fe76",
"darwin-386": "af352896aa6fa9d830a2b1f2fa0f5655d66372138ce5975c44fca4e4bdd85de1",
"linux-amd64": "4b7495539c84ecfb4256f1e7c8bcc9aea6732aef7360fd43ff239cea05d566c1",
"linux-386": "af93eb9d4722830940e74e6c018154c8182b31dd3ab5599fc7a3cdcdd472b37e",
"darwin-amd64": "9906ff1eb2cc01e53ba31f44a937300633b1f52ad227d9e206506c6c1b083a29",
"windows-386": "d819336b57a61c2676fb99352fead8aa567b454202e22670eec5833b04eb3a78",
"windows-amd64": "e79cbe016591832b85ce66f29c8180ebd8a45dcb793a44c9d3ff101bd7f3fe76",
"darwin-386": "af352896aa6fa9d830a2b1f2fa0f5655d66372138ce5975c44fca4e4bdd85de1",
"linux-amd64": "4b7495539c84ecfb4256f1e7c8bcc9aea6732aef7360fd43ff239cea05d566c1",
"linux-386": "af93eb9d4722830940e74e6c018154c8182b31dd3ab5599fc7a3cdcdd472b37e",
"darwin-amd64": "9906ff1eb2cc01e53ba31f44a937300633b1f52ad227d9e206506c6c1b083a29",
}

def _golangcilint_download_impl(ctx):
Expand All @@ -29,8 +29,8 @@ def _golangcilint_download_impl(ctx):
if arch not in _CHECKSUMS:
fail("Unsupported arch {}".format(arch))

url = _DOWNLOAD_URI.format(version=_VERSION, arch=arch)
prefix = _PREFIX.format(version=_VERSION, arch=arch)
url = _DOWNLOAD_URI.format(version = _VERSION, arch = arch)
prefix = _PREFIX.format(version = _VERSION, arch = arch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the formatting here (32-33) and on 13-18 change?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottgreenup It looks like this was changed by buildifier.

sha256 = _CHECKSUMS[arch]

ctx.template(
Expand Down
4 changes: 2 additions & 2 deletions gometalinter/deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ _GOMETALINTER_TARBALLS = {
"darwin_amd64": (
"gometalinter-2.0.10-darwin-amd64.tar.gz",
"gometalinter-2.0.10-darwin-amd64",
"b21c28a236f05d1cd1a394240388afdc3a20a2ddfeb34acb19c651d5d1936523"
"b21c28a236f05d1cd1a394240388afdc3a20a2ddfeb34acb19c651d5d1936523",
),
"linux_amd64": (
"gometalinter-2.0.10-linux-amd64.tar.gz",
"gometalinter-2.0.10-linux-amd64",
"111f656a8599349168544b9ae0dbc93240edcb28a81a92e9810ceaa40575545a"
"111f656a8599349168544b9ae0dbc93240edcb28a81a92e9810ceaa40575545a",
),
}

Expand Down