Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be resilient to file store errors #36

Open
3 tasks
MarshallOfSound opened this issue May 22, 2018 · 1 comment
Open
3 tasks

Be resilient to file store errors #36

MarshallOfSound opened this issue May 22, 2018 · 1 comment

Comments

@MarshallOfSound
Copy link
Contributor

Currently if an unhandled error occurs while transferring files from a TemporaryFile to a released File the operation is aborted but not cleaned up. This means the temporary file remains in the files store but the database entry has been removed.

  • Revert all DB modifications if any file store operation fails
  • Ensure file store deletions are the final operation to occur in any request and exclude them from the reversion logic ^^
  • Explore making file store changes transactional and also reversible (don't believe this is possible without storing everything in memory)
@b-zurg
Copy link

b-zurg commented May 11, 2020

I recently came across an issue like this. This is an important improvement to the platform I think because if something does go wrong in a production release then it can break releasing from then on - unless you manually go into the database - as then, at least with the bug I'm facing, the release file generation is completely broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants