Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent ppath inline code comments #533

Closed
m-brath opened this issue Sep 28, 2022 · 1 comment
Closed

Inconsistent ppath inline code comments #533

m-brath opened this issue Sep 28, 2022 · 1 comment
Assignees
Labels
bug Issues that make the package feel broken documentation Addition or update of the documentation

Comments

@m-brath
Copy link
Contributor

m-brath commented Sep 28, 2022

ppath inline code comments are inconsistent. For example according to documentation ppath.constant is used only in 1D but it is also used in 2D and 3D.

@erikssonpatrick : It would be nice if you can have a look on it.

@m-brath m-brath added bug Issues that make the package feel broken documentation Addition or update of the documentation labels Sep 28, 2022
@erikssonpatrick
Copy link
Contributor

I noticed that you had fixed a bug about longitudes. Thanks. When it comes to the comment. Wrong of you have found that ppath.constant used in some way also for 2D and 3D. Feel free to remove the comment.
Anyhow, I am a bit reluctant to spend time on the old code, to save it for my completely new version of ppath. In fact, I have got back to that the last weeks. Revised what I did last year and put it back in the present ARTS version. As well as some further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that make the package feel broken documentation Addition or update of the documentation
Projects
None yet
Development

No branches or pull requests

3 participants