Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala.js build #3

Closed
ngbinh opened this issue Apr 15, 2016 · 4 comments
Closed

Scala.js build #3

ngbinh opened this issue Apr 15, 2016 · 4 comments

Comments

@ngbinh
Copy link

ngbinh commented Apr 15, 2016

Is it something you consider? I can probably work on a PR due to our need.
@etorreborre
Copy link
Member

This is a great idea! I haven't had a close look at what it means to have a Scala.js build but I'd be happy to receive a PR for that.

@ngbinh
Copy link
Author

ngbinh commented Apr 19, 2016

the main obstacle I can see now is the test as we don't have a scala.js build for specs2 yet. I can probably only run test on the JVM for now.

@etorreborre
Copy link
Member

Unfortunately I need to find some time to work on spec2#465.

@benhutchison
Copy link
Collaborator

I could use this right now, got a cross-compiled lib I'd like to spike porting to Eff...

What if we just ran the specs on the jvm branch for now, and mentioned in the docs that the scala.js build is "beta" ie not yet directly tested? From my experience of scala.js, I guess the kinds of things Eff does are unlikely to be problematic converted to js, since they're well away from platform details.

@benhutchison benhutchison mentioned this issue Apr 30, 2016
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@etorreborre @benhutchison @ngbinh