fromFuture usage

[gabro]

Hey there, I've seen https://github.com/atnos-org/eff/blob/957fe5b514ee4afa6683fb803772234870749bb6/shared/src/main/scala/org/atnos/eff/AsyncFutureInterpreter.scala and I'm trying to figure out how to use fromFuture.

I have a few methods returning Future and I'd like to incorporate them inside my effect.

So, what I have so far is

  val interpreter = {
    import scala.concurrent.ExecutionContext.Implicits.global
    AsyncFutureInterpreter.create
  }
  import interpreter._

  def program[R : _config : _log : _async]: Eff[R, Future[String]] = for {
    config <- ask[R, Config]
    ip <- fromFuture(connect(config))
    _ <- tell(s"Listening on ${config.host}:${config.port}")
  } yield ip

and this compiles.

However, the fromFuture method comes from import interpreter._. So here I'm coupling the interpreter and the effect building.

Is there a way of working with existing futures in without coupling the specific interpreter?

[edmundnoble]

fromFuture is not an interpreter method, just because it belongs to the interpreter. It's a case of bad names. If you are working with Futures in Eff through Async, then you are working with the Future Async interpreter; it not only specifies how to get values out of an Eff value (interpretation), but how to get them in. They are tightly coupled, and that is the biggest reason I don't like Async.

If you don't want to use Async, you might be interested in trying bare Future.

[gabro]

It makes sense, thanks for the answer!

[etorreborre]

I agree this is not so nice and we should split the creation from the interpretation.