Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

apm assumes that the remote is called 'origin' => Package must pushed up to GitHub before publishing: #150

Closed
crucialfelix opened this issue Jul 14, 2014 · 2 comments
Assignees
Labels

Comments

@crucialfelix
Copy link

edit: as Daniel spotted, the issue is because my remote was called "github" instead of "origin"

source is here:

unless repo.getConfigValue('remote.origin.url')


its claimed that this bug is fixed, and it was suggested to reopen this if anybody sees it again.

I cannot publish. it is of course on github, so the error message is incorrect.

apm publish
Package must pushed up to GitHub before publishing: https://help.github.com/articles/create-a-repo

I've been through hundreds of threads and suggestions but nothing is working.

{
  "name": "supercollider",
  "version": "0.1.0",
  "description": "SuperCollider development environment for Atom",
  "repository": "https://github.com/crucialfelix/atom-supercollider.git",
  "homepage": "https://github.com/crucialfelix/atom-supercollider",
...
}

https://github.com/crucialfelix/atom-supercollider

[core]
  repositoryformatversion = 0
  filemode = true
  bare = false
  logallrefupdates = true
  ignorecase = true
  precomposeunicode = true
[remote "github"]
  url = https://github.com/crucialfelix/atom-supercollider.git
  fetch = +refs/heads/*:refs/remotes/github/*
  pushurl = https://github.com/crucialfelix/atom-supercollider.git
[branch "master"]
  remote = github
  merge = refs/heads/master
@thedaniel
Copy link
Contributor

Looking at the apm source, it seems apm checks that your github remote is named 'origin'. The code should instead probably check all the remotes for a github url rather than assuming the default name is used. In the meantime, if you temporarily change your remote name from 'github' to 'origin' I bet you can publish.

@crucialfelix
Copy link
Author

Good eye Daniel ! I was going to look through the apm source myself today.

We are up:

https://atom.io/packages/supercollider

I'm going to change the title and description of the bug.

@crucialfelix crucialfelix changed the title Package must pushed up to GitHub before publishing: apm assumes that the remote is called 'origin' => Package must pushed up to GitHub before publishing: Jul 15, 2014
@kevinsawicki kevinsawicki self-assigned this Jul 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants