This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
apm ci #806
Merged
apm ci #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating node and npm in #796 allows us to create
package-lock.jsonfiles, but nothing is currently reading them. Callingapm installwill only write a new lockfile if anything in the dependency tree has changed. Moderately useful for knowing when a dependency range is picking up a new version or when a transitive dependency has been updated, but not useful for creating reproducible builds (I'm looking at you, sporadically recurring "string_decoder" bug).This pull request adds
apm cias an analogue tonpm ci. Whenpackage-lock.jsonis present and synchronized with the dependencies inpackage.json, it blows away yournode_modules/and installs the exact, locked versions.