-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Conversation
😻 |
😋
The following should add extra padding if the left .platform-darwin {
atom-panel-container.left:empty + atom-workspace-axis.vertical .tab-bar {
padding-left: 100px;
}
} |
It seems that you can't drag the tabs. Probably issue electron/electron#3009. If we don't wanna wait for a fix, we could mimic a title bar that is full width. And maybe add the title to make some use of the space. .platform-darwin {
atom-panel.left {
padding-top: 0;
}
atom-workspace {
padding-top: 36px;
}
} |
Refs #4599 |
@simurai I bet we can work around this by creating dummy divs that take up the extra space in places we want draggable - basically, the bug revolves around visually overlapping |
@zcbenz Is there any clever trick that we can do to make tabs draggable in the non-client region? |
No, it has been a long hurting issue but we still don't know how to solve it. |
Oh cool. Crazy it's so little code. |
For now.. how about this:
It's not as compact as having the traffic lights next to the tabs. But on the other hand it gives a larger reserved area to drag around the window vs. the smaller space next to the tabs. |
Is this an osx only thing? How does it look on other platforms? |
Yeah, this only applies on OS X, other platforms will have the normal title bar |
This will be harder than one would assume from a CSS perspective, a lot of components use |
@paulcbetts Is this something that you're still interested in pursuing? Is it blocked by something? |
@lee-dohm I think we're going to do what @simurai mentioned above:
(#9274 is merged now!) Not sure if it will happen in this PR or not though. |
@benogle I'll have a look soonish |
It's been two months—can we get an update? Can we help somehow? 😁 |
It looks to me like the Brave guys have fixed it in their fork of Electron brave/muon#13 and it just needs merging upstream. |
The dragging issue seems to be fixed in electron/electron#5557 🔜 🔜 🔜 😻 |
@simurai 💖 |
Is there a way to apply these changes without compiling the whole app from scratch? |
@FezVrasta Nope |
@simurai Any update? I assume your last comment about the electron fix means we won't have to settle for the look where the buttons are above the tabs, it can all be inline 😃, and we can have the ideal solution proposed in the initial post. Is this correct? I hope so, that would mean there's only one more checkbox to go. So, any updates? (this is the feature I want the most out of Atom, it would really give it an awesome native feel.) |
Yeah, once Atom uses Electron But if, it probably should stay opt-in to not remove existing functionality, see #11790 (comment). Maybe like #11790 (comment). |
@50Wliu Hehe, ya, I meant Electron. Woops :P Some screenshots of hyperterm... |
@FezVrasta Thanks for sharing, but adding that code to my styles.less did not remove the titlebar in 1.11.0-beta0. The tabs and tree did move up, but I still have the default Mac titlebar. |
@smlombardi you have to compile the master to use this feature |
Ah, I was confused as the release notes for 1.11 simply say
Nothing about having to build my own atom. |
Ops sorry I didn't noticed it, then you just need to enable it from the settings 🙃 |
@smlombardi To hide macOS titlebar go to "Atom Beta" -> "Config…", and then under "core" add: |
Regarding "Figure out a way to make tabs draggable", isn't it possible to hide the titlebar altogether and make your own traffic lights using css like Nylas does? Wouldn't that make tabs draggable again because an invisible titlebar isn't in the way? |
No longer blocked. |
# Conflicts: # src/main-process/atom-window.coffee
Might get added again later.
to fit the traffic lights when `titleBarStyle = 'hidden-inset'` is used.
Ok, this PR currently looks like this: Difference to Hiding that custom title-barNow about entirely hiding the title-bar. It's not too hard in the default configuration, but it can get tricky if you consider all the possible options how people might use/customize Atom. Like when hiding the tree-view, the tabs need some padding: But not when you add a top panel (like the tool-bar package): Or what should happen if the left panel isn't wide enough, should the tab-bar add the padding? There are probably more edge cases. I can think of the following:
Any other ideas? |
So themes/packages can adapt to the custom title-bar
For Maybe good thing to test it out in a package/theme first. |
Superseded by #13616 |
@abduljamac Easiest way is to open the Atom |
This PR is mostly to get folx excited, because my CSS-fu is far too poor to make it actually work - on OS X, remove the Title Bar to fit in with other Yosemite apps - based on @simurai's design at https://discuss.atom.io/t/hide-system-window-title-bar/14578/8:
In safe mode:
TODO:
Closes #4599