Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

cmd+click multiple cursors not working #20916

Closed
alvarosalgado opened this issue Jun 10, 2020 · 16 comments · Fixed by #20804
Closed

cmd+click multiple cursors not working #20916

alvarosalgado opened this issue Jun 10, 2020 · 16 comments · Fixed by #20804

Comments

@alvarosalgado
Copy link

Hi,
My "cmd+click" multiple cursors functionality stopped working.
I tried disabling hyperclick inside atom-ide-ui, and also starting in safe mode. Nothing worked.
"cmd+d" and "ctrl+cmd+g" are still working.

Any clue?

@kitajchuk
Copy link

I suddenly have the same issue.

Specs:

Mac OS: 10.15.5 Beta (19F94a)
Atom: 1.48.0

@Atom-c
Copy link

Atom-c commented Jun 10, 2020

@alvarosalgado I was having the same issue and have a temporary workaround that brought functionality back in full for me 🙌

In your Atom config.cson (Atom > Config...) (or search for Config in Command Palette):

Add this (if core > editor is already present, just add the last line under there):

  core:
    editor:
      multiCursorOnClick: true

I did some backwards digging from the file change (#20444) that added the setting for this
atom.config.get('core.editor.multiCursorOnClick')
seems to point to nesting in core, whereas nesting under just editor did not register. You can also test this in the dev tools console.

atom.config.get('core.editor.multiCursorOnClick')
vs
atom.config.get('editor.multiCursorOnClick')

I'm not sure if this is a local issue due to conflicts across specific packages or a more widespread issue due to improper get() path?

I am not incredibly familiar with Atom despite my name.

Please let me know if the above fix works for you @alvarosalgado @kitajchuk — I hope so!


Additionally the release changelog for Atom 1.48.0 incorrectly links to a different change #20711; you should look at #20444:

#20711 Update npm to 6.14.4 for Python 3 support
#20711 Add setting to disable multi cursor on click

@Atom-c
Copy link

Atom-c commented Jun 10, 2020

@UziTech @lkashef any thoughts on the above?

I believe this is a duplicate of issue #20911

Update:
@UziTech's #20804 looks like it should fix this. In meantime the above workaround should help for folks having this issue.

# Atom config.cson

  core:
    editor:
      multiCursorOnClick: true

@seanoquinn
Copy link

seanoquinn commented Jun 11, 2020

This did not solve the issue for me.

Edit: added multiCursorOnClick in the hierarchy incorrectly the first time. Got it working now
image

@tommydunn
Copy link

I ended up reverting back to 1.47.0 while #20804 gets sorted. Thanks for figuring this out @UziTech

@softwarecreations
Copy link

softwarecreations commented Jun 11, 2020

Confirming Ctrl Click for multi-cursor is broken in Atom 1.48 on Linux.
However I can press ctrl-shift up/down arrow to get multi-cursor's that way, using the multi-cursor package, only Ctrl Click is not working.

Confirmed the issue in normal and atom --safe mode 1.48 and 1.47.
I don't use Hyperclick, I just found out about it because of this bug haha, will check it out.

Downgraded to 1.47 to be able to work.

@jinglesthula
Copy link

Thanks @UziTech for the quick fix PR. I use Atom, but am pretty unfamiliar w/ the development process. Wondering out loud to any and all if there's a possibility for an automated test for this to prevent future regressions?

@UziTech
Copy link
Contributor

UziTech commented Jun 11, 2020

@jinglesthula There were tests written for this feature but in this case the feature and the tests used the wrong config setting to check if it was enabled. #20804 fixes the feature and the tests.

@alvarosalgado
Copy link
Author

@alvarosalgado I was having the same issue and have a temporary workaround that brought functionality back in full for me 🙌

In your Atom config.cson (Atom > Config...) (or search for Config in Command Palette):

Add this (if core > editor is already present, just add the last line under there):

  core:
    editor:
      multiCursorOnClick: true

I did some backwards digging from the file change (#20444) that added the setting for this
atom.config.get('core.editor.multiCursorOnClick')
seems to point to nesting in core, whereas nesting under just editor did not register. You can also test this in the dev tools console.

atom.config.get('core.editor.multiCursorOnClick')
vs
atom.config.get('editor.multiCursorOnClick')

I'm not sure if this is a local issue due to conflicts across specific packages or a more widespread issue due to improper get() path?

I am not incredibly familiar with Atom despite my name.

Please let me know if the above fix works for you @alvarosalgado @kitajchuk — I hope so!

Additionally the release changelog for Atom 1.48.0 incorrectly links to a different change #20711; you should look at #20444:

#20711 Update npm to 6.14.4 for Python 3 support
#20711 Add setting to disable multi cursor on click
@Atom-c it worked like a charm! Thank you!

@AlexNodex
Copy link

Same issue...

Editing the config did not help... This is a massive regression for developers that use this functionality thousands of times a day :/

@UziTech
Copy link
Contributor

UziTech commented Jun 12, 2020

You can also open the console (Ctrl + Shift + I) and run atom.config.set('core.editor.multiCursorOnClick', true);

@simonrepp
Copy link

@AlexNodex It's easy to misplace the setting in "*" > editor instead of "*" > core > editor, and then it does not work - happened to me, happened to others (see @seanoquinn's post above with screenshot explanation), I suspect that's what happened for you as well.

@dead-claudia
Copy link

dead-claudia commented Jun 17, 2020

On Windows 10, I'm impacted by this (Ctrl instead of Cmd) and setting '*'.core.editor.multiCursorOnClick to true + reloading the tab worked. However, setting '*'.editor.multiCursorOnClick did not. This was all reproduced in safe mode.

PS> atom --version

Atom    : 1.48.0
Electron: 5.0.13
Chrome  : 73.0.3683.121
Node    : 12.0.0

Edit: had my steps listed wrong.

@putude
Copy link

putude commented Jun 21, 2020

@alvarosalgado I was having the same issue and have a temporary workaround that brought functionality back in full for me 🙌
In your Atom config.cson (Atom > Config...) (or search for Config in Command Palette):
Add this (if core > editor is already present, just add the last line under there):

  core:
    editor:
      multiCursorOnClick: true

I did some backwards digging from the file change (#20444) that added the setting for this
atom.config.get('core.editor.multiCursorOnClick')
seems to point to nesting in core, whereas nesting under just editor did not register. You can also test this in the dev tools console.
atom.config.get('core.editor.multiCursorOnClick')
vs
atom.config.get('editor.multiCursorOnClick')
I'm not sure if this is a local issue due to conflicts across specific packages or a more widespread issue due to improper get() path?
I am not incredibly familiar with Atom despite my name.
Please let me know if the above fix works for you @alvarosalgado @kitajchuk — I hope so!
Additionally the release changelog for Atom 1.48.0 incorrectly links to a different change #20711; you should look at #20444:

#20711 Update npm to 6.14.4 for Python 3 support
#20711 Add setting to disable multi cursor on click
@Atom-c it worked like a charm! Thank you!

Thank you, its work for me.
But I should use the combination CTRL+ALT + CLICK.

@dead-claudia
Copy link

@putude

But I should use the combination CTRL+ALT + CLICK.

It's possible you use an extension that rebinds it. I use Ctrl+Shift+click as I use Atom TypeScript.

@byronigoe
Copy link
Contributor

@isiahmeadows Thank you for this comment, as CTRL+Click does not work for me and neither the Keybinding Resolver nor the Atom TypeScript settings were any help in identifying why.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.