Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Line number showing double on soft wrap #2443

Closed
BlackWolf opened this issue May 29, 2014 · 6 comments · Fixed by #2423
Closed

Line number showing double on soft wrap #2443

BlackWolf opened this issue May 29, 2014 · 6 comments · Fixed by #2423

Comments

@BlackWolf
Copy link

Sometimes when having long lines and using soft wrap, the line number is repeated instead of showing a dot (this happens with line 26 in the first screenshot). The line numbers are correct (so the line displayed as 26 is line 26 and 27 starts where it should) and the content shows fine. Also, the markup seems fine as far as I can tell (see second screenshot).

The issue might be related to #2429

c29e2f3a3f40e620

screen shot 2014-05-29 at 18 39 15

@izuzak
Copy link
Contributor

izuzak commented May 29, 2014

@BlackWolf Do you have the React editor enabled in Atom > Preferences > Settings?

@BlackWolf
Copy link
Author

No, I don't, but this indeed fixes the issue! I can't find any information about what exactly the react editor is/does. Should it have been enabled by default?

@izuzak
Copy link
Contributor

izuzak commented May 29, 2014

No, I don't, but this indeed fixes the issue!

That's interesting - thanks for following up! Does this consistently happen for very long lines for you? If you can reliably reproduce the problem -- could you provide the steps to reproduce it?

I can't find any information about what exactly the react editor is/does.

It's a rewrite of the editor component. It's already in Atom, but it's opt-in until while we 🔨 at the rough edges.

Should it have been enabled by default?

No, it shouldn't. But it will be on by default soon (hopefully).

@BlackWolf
Copy link
Author

It seems to occur when having a file with long lines that can be scrolled - in some way, it is definitely related to scrolling, as it only occurs for lines that are outside of the current view and then scrolled into view, but I can't pinpoint the exact cause. When having such a file the issue can be reproduced by scrolling, though.

Kind of a "minimum" working example for me:

this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.
this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.
this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.
this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.
this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.
this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.
this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.this is a very long line.

(be sure to have the size of the atom window set in a way that the file needs to be scrolled to view the last view lines)

@izuzak
Copy link
Contributor

izuzak commented May 29, 2014

Thanks so much for that example, @BlackWolf -- that reproduces the issue for me as well!

Since this will be fixed with the React editor, I'll keep this open and just add fixes #2443 text to the pull request that makes the React editor default. 💡 /cc @nathansobo -- I'm guessing fixing this in the current editor is not worth the effort.

nathansobo pushed a commit that referenced this issue May 30, 2014
Fixes #2429, #2443

Otherwise, it's possible to duplicate lines. If a line is in the
rendered row range and it's not in the set of lines returned by the
editor, we should remove it no matter what. Line preservation is only
intended for lines that are out of view.
avdg pushed a commit to avdg/atom that referenced this issue Jun 9, 2014
Fixes atom#2429, atom#2443

Otherwise, it's possible to duplicate lines. If a line is in the
rendered row range and it's not in the set of lines returned by the
editor, we should remove it no matter what. Line preservation is only
intended for lines that are out of view.
@lock
Copy link

lock bot commented Jan 26, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants