New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large library size #7061

Closed
hryamzik opened this Issue Jun 2, 2015 · 58 comments

Comments

Projects
None yet
@hryamzik

hryamzik commented Jun 2, 2015

du -hs ~/Library/Application\ Support/com.github.atom.ShipIt/
9.0G

And there're 45 update.** files inside, 203M each. Seem to be a cleanup issue.

P.S.: Mac OS 10.10.3

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm
Member

lee-dohm commented Jul 3, 2015

@lee-dohm lee-dohm removed the mac label Jul 3, 2015

@friday

This comment has been minimized.

Show comment
Hide comment
@friday

friday Jul 16, 2015

This happened to me recently with Avast, and now with Atom (13 gb). So I guess my permissions might be set up "strangely". What should they be set to?

friday commented Jul 16, 2015

This happened to me recently with Avast, and now with Atom (13 gb). So I guess my permissions might be set up "strangely". What should they be set to?

@ptica

This comment has been minimized.

Show comment
Hide comment
@ptica

ptica Jul 16, 2015

2015-07-16 11:47:26.167 ShipIt[2380:1595531] Couldn't remove owned bundle at location file:///var/folders/57/pnpcvx2x62v4y48q575rmddr0000gn/T/com.github.atom.ShipIt.eeg3K3Ls/Atom.app, error NSError { domain: NSCocoaErrorDomain, code: 4, description: "“Atom.app” couldn’t be removed.", failureReason: "The file doesn’t exist.", underlying error: NSError { domain: NSPOSIXErrorDomain, code: 2, description: "The operation couldn’t be completed. No such file or directory" }, userInfo: {
    NSFilePath = "/var/folders/57/pnpcvx2x62v4y48q575rmddr0000gn/T/com.github.atom.ShipIt.eeg3K3Ls/Atom.app";
    NSUserStringVariant =     (
        Remove
    );
} }

ptica commented Jul 16, 2015

2015-07-16 11:47:26.167 ShipIt[2380:1595531] Couldn't remove owned bundle at location file:///var/folders/57/pnpcvx2x62v4y48q575rmddr0000gn/T/com.github.atom.ShipIt.eeg3K3Ls/Atom.app, error NSError { domain: NSCocoaErrorDomain, code: 4, description: "“Atom.app” couldn’t be removed.", failureReason: "The file doesn’t exist.", underlying error: NSError { domain: NSPOSIXErrorDomain, code: 2, description: "The operation couldn’t be completed. No such file or directory" }, userInfo: {
    NSFilePath = "/var/folders/57/pnpcvx2x62v4y48q575rmddr0000gn/T/com.github.atom.ShipIt.eeg3K3Ls/Atom.app";
    NSUserStringVariant =     (
        Remove
    );
} }
@ptica

This comment has been minimized.

Show comment
Hide comment
@ptica

ptica Jul 16, 2015

but the good news is that I've updated to 1.0.2 just now and the ~/Library/Application\ Support/com.github.atom.ShipIt/ got pruned to nearly zero!

ptica commented Jul 16, 2015

but the good news is that I've updated to 1.0.2 just now and the ~/Library/Application\ Support/com.github.atom.ShipIt/ got pruned to nearly zero!

@mgoffin

This comment has been minimized.

Show comment
Hide comment
@mgoffin

mgoffin Jul 27, 2015

I'm on 1.0.2 and just had this problem 14G of space used which filled the rest of my disk space.

mgoffin commented Jul 27, 2015

I'm on 1.0.2 and just had this problem 14G of space used which filled the rest of my disk space.

@benogle benogle added the atom label Jul 27, 2015

@kellyjandrews

This comment has been minimized.

Show comment
Hide comment
@kellyjandrews

kellyjandrews Aug 2, 2015

Same here - I'm currently at 8.9GB. Can we just delete these?

kellyjandrews commented Aug 2, 2015

Same here - I'm currently at 8.9GB. Can we just delete these?

@mgoffin

This comment has been minimized.

Show comment
Hide comment
@mgoffin

mgoffin Aug 2, 2015

Yep! I just nuke update.* and wait til it fills up again.

mgoffin commented Aug 2, 2015

Yep! I just nuke update.* and wait til it fills up again.

@LeviSchuck

This comment has been minimized.

Show comment
Hide comment
@LeviSchuck

LeviSchuck Aug 2, 2015

Ugh.. Seriously, so this is why I kept having to move stuff off my main boot partition.

16GB of past update stuff is irresponsible to leave around.

LeviSchuck commented Aug 2, 2015

Ugh.. Seriously, so this is why I kept having to move stuff off my main boot partition.

16GB of past update stuff is irresponsible to leave around.

@kellyjandrews

This comment has been minimized.

Show comment
Hide comment
@kellyjandrews

kellyjandrews Aug 3, 2015

@mgoffin Seems legit..... 👎

kellyjandrews commented Aug 3, 2015

@mgoffin Seems legit..... 👎

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Aug 12, 2015

Member

/cc @joshaber @robrix @keithduncan any ideas on this one from a squirrel point of view? Appreciate any help or insight you might have.

Member

kevinsawicki commented Aug 12, 2015

/cc @joshaber @robrix @keithduncan any ideas on this one from a squirrel point of view? Appreciate any help or insight you might have.

@LeviSchuck

This comment has been minimized.

Show comment
Hide comment
@LeviSchuck

LeviSchuck Aug 12, 2015

The updates are being accumulated, one after another, and when atom is shut down or started, don't know which, it applies the latest update and then deletes them all (On OSX at least)
However, if updates happen and you don't close Atom for a long time, it just keeps downloading more and more, without cleaning out the update directory, even though it doesn't destroy outdated updates.

LeviSchuck commented Aug 12, 2015

The updates are being accumulated, one after another, and when atom is shut down or started, don't know which, it applies the latest update and then deletes them all (On OSX at least)
However, if updates happen and you don't close Atom for a long time, it just keeps downloading more and more, without cleaning out the update directory, even though it doesn't destroy outdated updates.

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Aug 12, 2015

Contributor

@kevinsawicki Do we know what version of Squirrel we're using? It looks like we're downloading the framework pre-built from https://github.com/atom/atom-shell-frameworks/releases, but it's not clear what version of the framework that would be.

Squirrel/Squirrel.Mac#103 should, in theory, address what @LeviSchuck outlines above. But without knowing the Squirrel version we can't know if atom just needs to pick that fix up, or if there's something else going on.

Contributor

joshaber commented Aug 12, 2015

@kevinsawicki Do we know what version of Squirrel we're using? It looks like we're downloading the framework pre-built from https://github.com/atom/atom-shell-frameworks/releases, but it's not clear what version of the framework that would be.

Squirrel/Squirrel.Mac#103 should, in theory, address what @LeviSchuck outlines above. But without knowing the Squirrel version we can't know if atom just needs to pick that fix up, or if there's something else going on.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Aug 12, 2015

Member

@joshaber thanks for the details, @zcbenz do you know which version of Squirrel Electron is using currently?

Member

kevinsawicki commented Aug 12, 2015

@joshaber thanks for the details, @zcbenz do you know which version of Squirrel Electron is using currently?

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Aug 13, 2015

Member

I think we are using 0.1.5, which is released 6 months ago.

Member

zcbenz commented Aug 13, 2015

I think we are using 0.1.5, which is released 6 months ago.

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Aug 14, 2015

Contributor

In that case you'd definitely have Squirrel/Squirrel.Mac#103.

For those of you who get a bunch of updates built up, it'd be really great if you could save your ShipIt_stdout.log and ShipIt_stderr.log and paste them in here.

Contributor

joshaber commented Aug 14, 2015

In that case you'd definitely have Squirrel/Squirrel.Mac#103.

For those of you who get a bunch of updates built up, it'd be really great if you could save your ShipIt_stdout.log and ShipIt_stderr.log and paste them in here.

@friday

This comment has been minimized.

Show comment
Hide comment
@friday

friday Aug 14, 2015

@joshaber

My ShipIt_stdout.log is 0 bytes.
ShipIt_stderr.log seems to have relevant info, but the wrong path? http://pastebin.com/0x50SnaC

friday commented Aug 14, 2015

@joshaber

My ShipIt_stdout.log is 0 bytes.
ShipIt_stderr.log seems to have relevant info, but the wrong path? http://pastebin.com/0x50SnaC

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Aug 14, 2015

Contributor

Thanks @friday! 🤘

I'm adding this to my list to investigate.

Contributor

joshaber commented Aug 14, 2015

Thanks @friday! 🤘

I'm adding this to my list to investigate.

@StevenEWright

This comment has been minimized.

Show comment
Hide comment
@StevenEWright

StevenEWright Aug 24, 2015

+1

23.1 GB of space consumed.

StevenEWright commented Aug 24, 2015

+1

23.1 GB of space consumed.

@jacobtomlinson

This comment has been minimized.

Show comment
Hide comment
@jacobtomlinson

jacobtomlinson Sep 3, 2015

+1 4.4GB used

jacobtomlinson commented Sep 3, 2015

+1 4.4GB used

@50Wliu 50Wliu added auto-updater and removed installer labels Sep 4, 2015

@benharold

This comment has been minimized.

Show comment
Hide comment
@benharold

benharold Sep 8, 2015

I had this issue (approx 9 GB) but after quitting Atom and restarting my computer, the size of that directory went down to 8 KB (version 1.0.11).

benharold commented Sep 8, 2015

I had this issue (approx 9 GB) but after quitting Atom and restarting my computer, the size of that directory went down to 8 KB (version 1.0.11).

@cbess

This comment has been minimized.

Show comment
Hide comment
@cbess

cbess Sep 16, 2015

Same issue here, was 4GB (v1.0.11). When I restarted Atom (quit the app on Mac), it cleared the directory out.

cbess commented Sep 16, 2015

Same issue here, was 4GB (v1.0.11). When I restarted Atom (quit the app on Mac), it cleared the directory out.

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Sep 16, 2015

Contributor

I haven't been able to reproduce this personally yet.

One of my current theories is the app is sometimes quit & restarted before the app has the chance to perform the update. This is because there's a lengthy validation process that happens after downloading the update and before applying it. So then the app is launched again by the user, it downloads the update again, etc. This keeps happening until the app is quite for long enough for the update to apply and clean up.

For those of you who have experienced this, does that make sense with what you see? Or does that sound like nonsense?

Contributor

joshaber commented Sep 16, 2015

I haven't been able to reproduce this personally yet.

One of my current theories is the app is sometimes quit & restarted before the app has the chance to perform the update. This is because there's a lengthy validation process that happens after downloading the update and before applying it. So then the app is launched again by the user, it downloads the update again, etc. This keeps happening until the app is quite for long enough for the update to apply and clean up.

For those of you who have experienced this, does that make sense with what you see? Or does that sound like nonsense?

@mgoffin

This comment has been minimized.

Show comment
Hide comment
@mgoffin

mgoffin Sep 16, 2015

To reproduce: open Atom and never close it.

mgoffin commented Sep 16, 2015

To reproduce: open Atom and never close it.

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Dec 30, 2015

Contributor

Has anyone seen this recently?

Contributor

joshaber commented Dec 30, 2015

Has anyone seen this recently?

@SlvrEagle23

This comment has been minimized.

Show comment
Hide comment
@SlvrEagle23

SlvrEagle23 Jan 3, 2016

@joshaber Can verify that this is still happening as of Atom 1.3.2. Only very recently installed Atom on my Mac, left it running in the background through a few wake/sleep cycles, came back to a "disk space usage" warning with 15GB of space taken solely by the ~/Library/Application\ Support/com.github.atom.ShipIt/ folder. Cleaning up the folder seems to be without side effect, as the app launched fine anyway and didn't try to repopulate the giant folder.

SlvrEagle23 commented Jan 3, 2016

@joshaber Can verify that this is still happening as of Atom 1.3.2. Only very recently installed Atom on my Mac, left it running in the background through a few wake/sleep cycles, came back to a "disk space usage" warning with 15GB of space taken solely by the ~/Library/Application\ Support/com.github.atom.ShipIt/ folder. Cleaning up the folder seems to be without side effect, as the app launched fine anyway and didn't try to repopulate the giant folder.

@lokenx

This comment has been minimized.

Show comment
Hide comment
@lokenx

lokenx Jan 13, 2016

Any idea if this is still an issue? Just realized mine is 79 GB (!?) on OS X 10.10.5 and Atom 1.3.3.

Is it safe to just delete all these files, or should I keep them around for now testing (I've 20 GB free still on my 256 GB SSD so I don't need to clear the space just yet).

lokenx commented Jan 13, 2016

Any idea if this is still an issue? Just realized mine is 79 GB (!?) on OS X 10.10.5 and Atom 1.3.3.

Is it safe to just delete all these files, or should I keep them around for now testing (I've 20 GB free still on my 256 GB SSD so I don't need to clear the space just yet).

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Jan 13, 2016

Contributor

@lokenx It looks like some people are still experiencing it unfortunately 😞 Feel free to delete all those files.

Contributor

joshaber commented Jan 13, 2016

@lokenx It looks like some people are still experiencing it unfortunately 😞 Feel free to delete all those files.

@lokenx

This comment has been minimized.

Show comment
Hide comment
@lokenx

lokenx Jan 13, 2016

OK thanks! I'm glad I noticed before my disk ran out of space 😟

Regardless, keep up the good work!

Edit: it seems to have cleared itself up, not sure if it was restarting or opening Atom or what.

lokenx commented Jan 13, 2016

OK thanks! I'm glad I noticed before my disk ran out of space 😟

Regardless, keep up the good work!

Edit: it seems to have cleared itself up, not sure if it was restarting or opening Atom or what.

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Jan 13, 2016

Contributor

@lokenx Oh interesting! Had you launched/restarted Atom in a while?

Contributor

joshaber commented Jan 13, 2016

@lokenx Oh interesting! Had you launched/restarted Atom in a while?

@lokenx

This comment has been minimized.

Show comment
Hide comment
@lokenx

lokenx Jan 13, 2016

I don't believe so. I'd been off work for a number of months (broken knee). The machine was on but not in use, and no one else uses. I started Atom to get the version number off it and then closed down--maybe that was enough. It was already on 1.3.3 without me updating either (background updates?).

lokenx commented Jan 13, 2016

I don't believe so. I'd been off work for a number of months (broken knee). The machine was on but not in use, and no one else uses. I started Atom to get the version number off it and then closed down--maybe that was enough. It was already on 1.3.3 without me updating either (background updates?).

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 22, 2016

Mine is 4.3GB. Atom v1.6.2. Will this be addressed soon?

seangates commented Apr 22, 2016

Mine is 4.3GB. Atom v1.6.2. Will this be addressed soon?

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Apr 22, 2016

Member

@seangates How did you install Atom? Have you not restarted Atom recently?

Member

lee-dohm commented Apr 22, 2016

@seangates How did you install Atom? Have you not restarted Atom recently?

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 22, 2016

@lee-dohm I have had it open for a few days, as I usually go a few weeks without restarting it. Is that part of the issue?

Also, I originally installed it about a year ago, and have been getting regular automatic updates over time, whenever I have restarted my machine.

seangates commented Apr 22, 2016

@lee-dohm I have had it open for a few days, as I usually go a few weeks without restarting it. Is that part of the issue?

Also, I originally installed it about a year ago, and have been getting regular automatic updates over time, whenever I have restarted my machine.

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Apr 22, 2016

Member

Well, the latest version is v1.7.2. I'm not sure when it clears out the old versions that have been downloaded. So if you're not restarting I assume it could be downloading multiple new versions and not clearing them out until the restart happens?

Member

lee-dohm commented Apr 22, 2016

Well, the latest version is v1.7.2. I'm not sure when it clears out the old versions that have been downloaded. So if you're not restarting I assume it could be downloading multiple new versions and not clearing them out until the restart happens?

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 22, 2016

@lee-dohm Let me restart Atom and see if the large file persists.

seangates commented Apr 22, 2016

@lee-dohm Let me restart Atom and see if the large file persists.

@gerrywastaken

This comment has been minimized.

Show comment
Hide comment
@gerrywastaken

gerrywastaken Apr 23, 2016

@lee-dohm I just ran Atom/Update and Restart. During the update I watched the updates directory. A new directory called update.15SjUvX was created and then deleted shortly after.

I'm not sure about the initial conditions that lead to update files building up in the directory. However this is a good sign.

gerrywastaken commented Apr 23, 2016

@lee-dohm I just ran Atom/Update and Restart. During the update I watched the updates directory. A new directory called update.15SjUvX was created and then deleted shortly after.

I'm not sure about the initial conditions that lead to update files building up in the directory. However this is a good sign.

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 25, 2016

The issue persists. The file is still 4.31GB after restart on v1.6.2. I'm updating to v1.7.2 to see if it solves the issue.

seangates commented Apr 25, 2016

The issue persists. The file is still 4.31GB after restart on v1.6.2. I'm updating to v1.7.2 to see if it solves the issue.

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 25, 2016

Yeah, updated to v1.7.2, still have a 4.31GB ShipIt_stderr.log file.

seangates commented Apr 25, 2016

Yeah, updated to v1.7.2, still have a 4.31GB ShipIt_stderr.log file.

@gerrywastaken

This comment has been minimized.

Show comment
Hide comment
@gerrywastaken

gerrywastaken Apr 25, 2016

@seangates I didn't think this issue was ever about the stderr.log file being too big. I believe it was about having many redundant update directories which were massive. Not having pruning on the error log is another issue which I don't believe has been mentioned here until your comment.

gerrywastaken commented Apr 25, 2016

@seangates I didn't think this issue was ever about the stderr.log file being too big. I believe it was about having many redundant update directories which were massive. Not having pruning on the error log is another issue which I don't believe has been mentioned here until your comment.

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 25, 2016

@gerrywastaken Okay. Should there be a new issue raised?

seangates commented Apr 25, 2016

@gerrywastaken Okay. Should there be a new issue raised?

@gerrywastaken

This comment has been minimized.

Show comment
Hide comment
@gerrywastaken

gerrywastaken Apr 25, 2016

@samlambert Yes, or looking at what was in the error log. Perhaps that points to something that should be fixed? Part of me thinks that it's a good thing that the error log grows large, because then at least it grabs attention.

If it's stuff that is no longer relevant then it probably shouldn't be filling up the hard drives of people who haven't realised what the issue is.

I'm not a maintainer so I'll defer to @nathansobo, who closed this issue, so probably knows what should be done regarding the error log file size.

gerrywastaken commented Apr 25, 2016

@samlambert Yes, or looking at what was in the error log. Perhaps that points to something that should be fixed? Part of me thinks that it's a good thing that the error log grows large, because then at least it grabs attention.

If it's stuff that is no longer relevant then it probably shouldn't be filling up the hard drives of people who haven't realised what the issue is.

I'm not a maintainer so I'll defer to @nathansobo, who closed this issue, so probably knows what should be done regarding the error log file size.

@seangates

This comment has been minimized.

Show comment
Hide comment
@seangates

seangates Apr 25, 2016

@gerrywastaken Well, since it was an error log ... I deleted it. So, I don't know what's in it anymore. But, I assume it was simply for logging purposes to diagnose issues. The fact that it was over 4GB is concerning, though, as it should be pruned periodically. Or the log should be broken in to date ranges and pruned according to date ranges, like the last 5 days or something. (Configurable, maybe?)

Anyhow, it looks like my issue is different that stated in this issue, so I'll stop replying. 😉

seangates commented Apr 25, 2016

@gerrywastaken Well, since it was an error log ... I deleted it. So, I don't know what's in it anymore. But, I assume it was simply for logging purposes to diagnose issues. The fact that it was over 4GB is concerning, though, as it should be pruned periodically. Or the log should be broken in to date ranges and pruned according to date ranges, like the last 5 days or something. (Configurable, maybe?)

Anyhow, it looks like my issue is different that stated in this issue, so I'll stop replying. 😉

@gerrywastaken

This comment has been minimized.

Show comment
Hide comment
@gerrywastaken

gerrywastaken May 22, 2016

@lee-dohm Since my comment 29 days ago: #7061 (comment)

The directory has started filling up again.
screen shot 2016-05-23 at 2 44 35 am

Closing Atom does remove a lot of the data from inside the "update.djksja" directories, but if the user needs to periodically restart Atom, I'm not sure that is a great default behaviour. It does also leave the directories in place. I'm not sure if this is expected.

gerrywastaken commented May 22, 2016

@lee-dohm Since my comment 29 days ago: #7061 (comment)

The directory has started filling up again.
screen shot 2016-05-23 at 2 44 35 am

Closing Atom does remove a lot of the data from inside the "update.djksja" directories, but if the user needs to periodically restart Atom, I'm not sure that is a great default behaviour. It does also leave the directories in place. I'm not sure if this is expected.

@ahundt

This comment has been minimized.

Show comment
Hide comment
@ahundt

ahundt May 25, 2016

I still have this problem as well, I'm trying to figure out how to simply delete atom so it stops and I can't figure that out either!

ahundt commented May 25, 2016

I still have this problem as well, I'm trying to figure out how to simply delete atom so it stops and I can't figure that out either!

@ahundt

This comment has been minimized.

Show comment
Hide comment
@ahundt

ahundt May 25, 2016

I haven't been able to totally remove atom (which I would like) but I've been able to get the log to stop printing with:

 launchctl stop com.github.GitHub.ShipIt

ahundt commented May 25, 2016

I haven't been able to totally remove atom (which I would like) but I've been able to get the log to stop printing with:

 launchctl stop com.github.GitHub.ShipIt

@stale stale bot added the stale label Aug 29, 2017

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Aug 29, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot commented Aug 29, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this Sep 12, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Mar 30, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

lock bot commented Mar 30, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked and limited conversation to collaborators Mar 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.